fix folders issues

[kfirstri]

No description provided.

[github-actions]

🚀 Package Preview Available!

---

Install this PR's preview build with npm:

npm i @base44-preview/cli@0.0.1-pr.15.8b10ac1

Prefer not to change any import paths? Install using npm alias so your code still imports base44:

npm i "base44@npm:@base44-preview/cli@0.0.1-pr.15.8b10ac1"

Or add it to your package.json dependencies:

{
  "dependencies": {
    "base44": "npm:@base44-preview/cli@0.0.1-pr.15.8b10ac1"
  }
}

• 📦 Preview Package: @base44-preview/cli@0.0.1-pr.15.8b10ac1
• 🔗 View this commit on GitHub

---

_{Preview published to npm registry — try new features instantly!}

[claude]

Pull Request Review: Fix folders issues

Overview

This PR refactors the folder structure by renaming src/core/config/ to src/core/project/ and reorganizing files within it. The changes improve semantic organization by separating project-specific configuration from other concerns.

✅ Strengths

1. Better Semantic Organization: Renaming config/ to project/ is clearer since these files handle project-specific resources and configuration, not general app configuration.

2. Consistent Import Updates: All imports have been correctly updated across the codebase:

   • src/cli/commands/project/show-project.ts:1
   • src/core/resources/entity/resource.ts:1
   • src/core/resources/function/resource.ts:1
   • tests/core/project.test.ts:2

3. File Renaming Clarity:

   • config/project.ts → project/config.ts (more logical naming)
   • config/app.ts → project/schema.ts (better reflects content)
   • config/baseResource.ts → project/baseResource.ts (keeps resource pattern together)

4. Zero Breaking Changes: The refactor is purely internal with updated barrel exports maintaining the same public API.

⚠️ Issues Found

Critical: Documentation Out of Sync

The AGENTS.md file still references the old folder structure and needs to be updated:

Lines 44-48 reference the old structure:

├── config/              # Project/app configuration
│   ├── resource.ts      # Resource<T> interface
│   ├── project.ts       # Project loading logic
│   ├── app.ts
│   └── index.ts

Lines 68 and 97 still show old import paths:

// Line 68: Resource Interface (config/resource.ts)
// Line 97: import { readProjectConfig } from "@core/config/project.js";

Recommendation: Update AGENTS.md to reflect the new project/ folder structure with correct file names (config.ts, schema.ts, etc.) and import paths.

Minor: PR Description

The PR title "fix folders issues" and empty body don't describe what was fixed or why the refactoring was necessary. Consider adding context about the organizational improvement.

🔍 Code Quality Assessment

Architecture: ✅ Good - Improves logical separation of concerns
Type Safety: ✅ Maintained - No changes to types
Testing: ✅ Tests updated correctly
Imports: ✅ All imports use proper .js extensions (ES modules)
Path Aliases: ✅ Correctly uses @core/ alias

🚀 Performance

No performance impact - purely organizational refactor.

🔒 Security

No security concerns identified.

🧪 Test Coverage

Existing test coverage maintained. Test file correctly updated to use new import path.

📝 Action Items

1. Required: Update AGENTS.md to match the new folder structure:

   • Update folder tree (lines 44-48)
   • Update code examples (lines 68, 97)
   • Update "Adding a New Resource" section (line 86) to reference project/baseResource.ts

2. Optional: Add a descriptive PR body explaining the rationale for this refactoring.

Conclusion

This is a solid refactoring that improves code organization. The only blocker is updating the documentation to match the new structure. Once AGENTS.md is updated, this PR should be good to merge.

Recommendation: Request changes to update documentation before merging.