chore(logging): enable rotated logging for supervisord to improve debugging#935
Open
chore(logging): enable rotated logging for supervisord to improve debugging#935
Conversation
…and 10 backups Replaces /dev/null with a proper logfile in /var/log/supervisord/supervisord.log, adds rotation and info loglevel. Improves debugging for supervisord events without affecting container stdout logs.
Collaborator
🟡 Heimdall Review Status
|
|
Great improvement for debugging! Having rotated supervisord logs is essential for diagnosing restart loops. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / Why we need it:
Currently, supervisord activity logs are discarded to
/dev/null, making it impossible to debug supervisord itself (e.g., process restarts, config issues, errors).This PR enables proper rotated logging for the supervisord activity log:
Program stdout/stderr remain redirected to container stdout (visible via
docker compose logs), no changes there.Changes:
Verification (tested locally on WSL2 + Docker Desktop):
docker compose up -d --build→ Services start successfully.docker compose logs→ No loss of program output; supervisord events now loggable (if issues occur).References:
Open to adjustments (e.g., different path, size, or per-program logs). Thanks for reviewing!