feat(review): toggle review layouts#421
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Review buffers currently make users choose either a generated map layout or the side-by-side split layout up front. Moving between those layouts requires rerunning the review command and manually reselecting the same file, which interrupts review flow.
Solution
Add a review layout toggle that switches generated review maps into split review panes and returns split panes to the originating generated layout. The toggle preserves the selected review file across transitions, records review surface metadata on generated and split buffers, and exposes both a buffer-local
gsmapping and a publicreview_toggle_layout()API.