chore(deps): bump packaging from 26.0 to 26.2#8971
Conversation
Bumps [packaging](https://github.com/pypa/packaging) from 26.0 to 26.2. - [Release notes](https://github.com/pypa/packaging/releases) - [Changelog](https://github.com/pypa/packaging/blob/main/CHANGELOG.rst) - [Commits](pypa/packaging@26.0...26.2) --- updated-dependencies: - dependency-name: packaging dependency-version: '26.2' dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
aws-sam-cli-bot
left a comment
There was a problem hiding this comment.
Code Review Results
Reviewed: 9f13e3d..4c2f6e9
Files: 4
Comments: 1
Comments on lines outside the diff:
[requirements/reproducible-linux.txt:81] [GENERAL] The PR title states bump packaging from 26.0 to 26.2, but the diff contains substantive changes beyond the packaging bump that are not mentioned in the description:
binaryornotis downgraded from0.6.0to0.4.4(also applied inreproducible-mac.txt:81andreproducible-win.txt:81).chardet==5.2.0is added as a new transitive dependency in all three lock files.installer/pyinstaller/hook-samcli.pydrops thehooks.collect_all("binaryornot", ...)entry and its explanatory comment.
These changes are internally consistent (binaryornot 0.4.4 does not use the binaryornot.data / importlib.resources.files() pattern that required the PyInstaller hook, and chardet is pulled in because 0.4.4 depends on it), but they are functionally a downgrade of a transitive dependency across ~7 years of releases (0.4.4 shipped in 2017, 0.6.0 in 2024), not a version bump. A silent regression like this is easy to miss for reviewers scanning only the title/description, and it will be misrepresented in any changelog derived from the PR metadata.
Two concrete concerns:
- The PR title/description should be updated to call out the binaryornot downgrade and the reason for it (presumably to avoid the PyInstaller
importlib.resources.files()collection issue referenced in the removed comment), or the non-packagingchanges should be split into a separate PR so each change is reviewed on its own merits. - If the binaryornot downgrade is intentional as a PyInstaller workaround, consider whether keeping binaryornot at 0.6.0 with the existing
collect_allhook is preferable to regressing the library itself — the current hook entry already solved that problem, so the rationale for dropping it alongside the downgrade is worth making explicit in the PR description.
vicheey
left a comment
There was a problem hiding this comment.
Approved: dependabot dependency update.
Bumps packaging from 26.0 to 26.2.
Release notes
Sourced from packaging's releases.
... (truncated)
Changelog
Sourced from packaging's changelog.
... (truncated)
Commits
84a87eeBump for release4a616b6docs: a few more updates to prepare for 26.2 (#1176)9de6f44ci: use native uv integration in rtd (#1175)bc76e14chore: update changelog for 26.2 (#1161)3f00091tests: add a pickle check (#1174)48a8a06fix: make Requirements/Markers pickle-safe (#1171)823b44efix: make Tags pickle-safe (#1170)4bed32dfix: make Specifier / SpecifierSet pickle-safe (#1168)963118efix: re-export ExceptionGroup for now (#1164)66e34a8docs(specifiers): add is_unsatisfiable() usage example (#1166)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)