chore(deps-dev): bump types-docutils from 0.22.3.20260322 to 0.22.3.20260508#8970
Conversation
Bumps [types-docutils](https://github.com/python/typeshed) from 0.22.3.20260322 to 0.22.3.20260508. - [Commits](https://github.com/python/typeshed/commits) --- updated-dependencies: - dependency-name: types-docutils dependency-version: 0.22.3.20260508 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
dependabot
Bot
added
python
aws-sam-cli-bot
left a comment
aws-sam-cli-bot
left a comment
There was a problem hiding this comment.
Code Review Results
Reviewed: 9f13e3d..ef35935
Files: 5
Comments: 1
Comments on lines outside the diff:
[installer/pyinstaller/hook-samcli.py:18] [GENERAL] This PR is titled as a Dependabot dev-deps bump for types-docutils (0.22.3.20260322 → 0.22.3.20260508), but the diff also contains unrelated, production-impacting changes that a reviewer trusting the chore(deps-dev) label could easily miss:
binaryornotis downgraded from0.6.0to0.4.4in all threerequirements/reproducible-{linux,mac,win}.txtfiles (line 81 in each).chardet==5.2.0is newly pinned as a transitive dependency (# via binaryornot) in all three lockfiles (lines 203–206).- This file removes the
hooks.collect_all("binaryornot", include_py_files=False)[0]entry and the accompanying comment explaining thatbinaryornot 0.6.0moved its tables into abinaryornot.datasubpackage loaded viaimportlib.resources.files().
Items 2 and 3 are internally consistent with each other (0.4.4 predates the binaryornot.data subpackage, so the PyInstaller hook is no longer required), but they are not related to types-docutils and together they revert a previously-added fix for binaryornot 0.6.0 packaging under PyInstaller. binaryornot is pulled in at runtime via cookiecutter (used by sam init), so this is a user-visible change, not just a dev-deps bump.
Please either:
- Split the
binaryornotdowngrade + hook removal into its own PR with a clear justification (and verifysam initstill works when invoked from the PyInstaller-packaged binary — that path is exactly what the removed hook was protecting), or - Regenerate this Dependabot PR from a clean base so only the
types-docutilsline and its hashes change.
vicheey
left a comment
vicheey
left a comment
There was a problem hiding this comment.
Approved: dependabot dependency update.
dependabot
Bot
deleted the
dependabot/pip/develop/types-docutils-0.22.3.20260508
branch
3 participants
Bumps types-docutils from 0.22.3.20260322 to 0.22.3.20260508.
Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)