Skip to content

feat: add AWS_LWA_PROXY_LAMBDA_RUNTIME_API to overwrite#588

Merged
bnusunny merged 3 commits into
aws:mainfrom
alexgallotta:main
Apr 12, 2025
Merged

feat: add AWS_LWA_PROXY_LAMBDA_RUNTIME_API to overwrite#588
bnusunny merged 3 commits into
aws:mainfrom
alexgallotta:main

Conversation

@alexgallotta

Copy link
Copy Markdown
Contributor

AWS_LAMBDA_RUNTIME_API and use a proxy

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

AWS_LAMBDA_RUNTIME_API and use a proxy
@alexgallotta alexgallotta requested a review from a team as a code owner April 4, 2025 14:15
@bnusunny

bnusunny commented Apr 5, 2025

Copy link
Copy Markdown
Contributor

Nice to see this PR. I like that it proxies the runtime calls only, not the extension registration calls. This avoids the race condition between extensions.

One miner thing about env var name: I prefer to call it AWS_LWA_LAMBDA_RUNTIME_API_PROXY. And could you add a small paragraph to explain the use case of this env var? Like what we have for other configuration env vars.

@alexgallotta

Copy link
Copy Markdown
Contributor Author

Thanks for the review! I renamed the env and added some doc.
Let me know if it looks good!

@bnusunny bnusunny left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bnusunny bnusunny merged commit 9a96644 into aws:main Apr 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants