Skip to content

Remove "transfer-encoding" header from responses#442

Merged
bnusunny merged 3 commits into
mainfrom
remote-hop-by-hop-headers
Apr 20, 2024
Merged

Remove "transfer-encoding" header from responses#442
bnusunny merged 3 commits into
mainfrom
remote-hop-by-hop-headers

Conversation

@bnusunny

@bnusunny bnusunny commented Apr 19, 2024

Copy link
Copy Markdown
Contributor

Description of changes:

This change removes "transfer-encoding" http header from web app response. This resolves an issue that sam local start-api fails to handle the chunked response from SpringBoot.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@bnusunny bnusunny requested a review from mbfreder April 19, 2024 09:03
@bnusunny bnusunny changed the title Remove hop-by-hop headers from requests and responses Remove hop-by-hop headers from responses Apr 19, 2024
Comment thread src/lib.rs Outdated
@bnusunny bnusunny changed the title Remove hop-by-hop headers from responses [WIP] Remove hop-by-hop headers from responses Apr 19, 2024
@bnusunny

Copy link
Copy Markdown
Contributor Author

I need to double check if this is the right place to remove these headers. At least 'transfer-encoding' is used in lambda-http crate to handle response body.

@bnusunny bnusunny changed the title [WIP] Remove hop-by-hop headers from responses [WIP] Remove "transfer-encoding" header from responses Apr 20, 2024
@bnusunny bnusunny changed the title [WIP] Remove "transfer-encoding" header from responses Remove "transfer-encoding" header from responses Apr 20, 2024
@bnusunny

Copy link
Copy Markdown
Contributor Author

I confirmed 'transfer-encoding' is not used in lambda-http crate to handle response body.

@bnusunny bnusunny merged commit 035659c into main Apr 20, 2024
@bnusunny bnusunny deleted the remote-hop-by-hop-headers branch April 20, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants