Skip to content

Support serialize UTF-8 String in HTTP Header Values#800

Merged
calavera merged 7 commits into
mainfrom
support-utf-8-in-header-value
Jan 29, 2024
Merged

Support serialize UTF-8 String in HTTP Header Values#800
calavera merged 7 commits into
mainfrom
support-utf-8-in-header-value

Conversation

@bnusunny

Copy link
Copy Markdown
Collaborator

Issue #, if available:

close #786

Description of changes:

Support serialize UTF-8 String in HTTP Header Values

By submitting this pull request

  • I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • I confirm that I've made a best effort attempt to update all relevant documentation.

@bnusunny bnusunny requested a review from calavera January 28, 2024 13:48

@calavera calavera left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some tests to prevent regressions?

@bnusunny bnusunny requested a review from calavera January 28, 2024 23:58
@bnusunny

Copy link
Copy Markdown
Collaborator Author

Added a test to cover both serialize_headers and serialize_multi_value_headers.

@calavera calavera merged commit 2652b45 into main Jan 29, 2024
@calavera calavera deleted the support-utf-8-in-header-value branch January 29, 2024 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

thread 'main' panicked at 'lambda runtime failed: Error("failed to convert header to a str", line: 0, column: 0)'

2 participants