ecsservicediscovery: Add ec2 instance ID to exported labels#2048
Open
ecsservicediscovery: Add ec2 instance ID to exported labels#2048
Conversation
Author
Contributor
|
This PR was marked stale due to lack of activity. |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the issue
It would be nice to have access to the ec2 instance ID the ECS task is running on as a label.
Description of changes
Add the ec2 instance ID as a label.
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Added it to unit tests.
Requirements
make fmtandmake fmt-sh✅make lint✅Integration Tests
To run integration tests against this PR, add the
ready for testinglabel.