Skip to content

fix: ensure agentcore create exits after completion in non-interactiv…#218

Merged
tejaskash merged 1 commit into
mainfrom
fix/199-create-exit-noninteractive
Feb 10, 2026
Merged

fix: ensure agentcore create exits after completion in non-interactiv…#218
tejaskash merged 1 commit into
mainfrom
fix/199-create-exit-noninteractive

Conversation

@notgitika
Copy link
Copy Markdown
Contributor

…e mode (#199)

Closes #199

Description

When running agentcore create with --json flag, the process hangs instead of exiting after completion. Three issues were fixed:

  1. --json and --dry-run flags now route to CLI mode (matching the deploy command pattern) instead of falling through to TUI mode
  2. The standalone TUI auto-exits after successful project creation — the isInteractive guard on the auto-exit useEffect was preventing this
  3. handleCreateTUI's onExit callback now calls process.exit(0) after unmounting (matching the deploy command pattern)

Related Issues

#199

Documentation PR

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Other (please describe):

Testing

How have you tested the change?

  • I ran npm run test:all
  • I ran npm run typecheck
  • I ran npm run lint
  • If I modified src/assets/, I ran npm run test:update-snapshots and committed the updated snapshots

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.

@notgitika notgitika requested a review from a team February 10, 2026 00:54
@github-actions
Copy link
Copy Markdown
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 7.26% 473 / 6514
🔵 Statements 6.93% 481 / 6931
🔵 Functions 4.25% 57 / 1341
🔵 Branches 5.15% 194 / 3760
Generated in workflow #201 for commit ffadc3f by the Vitest Coverage Report Action

@tejaskash tejaskash merged commit 2ac14a1 into main Feb 10, 2026
14 checks passed
@tejaskash tejaskash deleted the fix/199-create-exit-noninteractive branch February 10, 2026 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Agentcore create doesn't exit after completion in non-interactive mode

2 participants