Skip to content

fix(deploy): preserve error typing through CDK wrapper and preflight#1459

Merged
jariy17 merged 5 commits into
aws:mainfrom
Hweinstock:refactor/remove-cdk-error-wrapper
Jun 3, 2026
Merged

fix(deploy): preserve error typing through CDK wrapper and preflight#1459
jariy17 merged 5 commits into
aws:mainfrom
Hweinstock:refactor/remove-cdk-error-wrapper

Conversation

@Hweinstock
Copy link
Copy Markdown
Contributor

@Hweinstock Hweinstock commented Jun 3, 2026

Description

Problem

High rate of unknown errors from deploy in telemetry. There are a few places this could happen:

  1. withErrorContext discarded all error typing by recreating errors as generic errors.
  2. Preflight/teardown user errors were thrown as plain Error.

Net effect: deploy failures now carry their real type through to telemetry and error handling.

Related Issue

Closes #

Documentation PR

N/A — no user-facing documentation changes; this only affects internal error typing/telemetry classification.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Other (please describe):

Testing

How have you tested the change?

  • I ran npm run test:unit and npm run test:integ
  • I ran npm run typecheck
  • I ran npm run lint
  • If I modified src/assets/, I ran npm run test:update-snapshots and committed the updated snapshots

Notes:

  • typecheck and lint pass on the changed files (wrapper.ts, actions.ts, preflight.ts).
  • Full test:unit was not run cleanly in this environment due to a missing optional dependency unrelated to this change. The one failing test observed (LogsScreen > shows error when no runtimes are defined) reproduces identically on origin/main with these changes stashed, so it is pre-existing and not a regression.

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.

@github-actions github-actions Bot added the size/s PR size: S label Jun 3, 2026
@github-actions github-actions Bot added the agentcore-harness-reviewing AgentCore Harness review in progress label Jun 3, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added the claude-security-reviewing Claude Code /security-review in progress label Jun 3, 2026
@agentcore-devx-automation
Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 3, 2026

Package Tarball

aws-agentcore-0.17.0.tgz

How to install

gh release download pr-1459-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.17.0.tgz

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label Jun 3, 2026
@github-actions github-actions Bot removed the agentcore-harness-reviewing AgentCore Harness review in progress label Jun 3, 2026
@Hweinstock Hweinstock marked this pull request as ready for review June 3, 2026 23:09
@Hweinstock Hweinstock requested a review from a team June 3, 2026 23:09
@jariy17 jariy17 merged commit 3126905 into aws:main Jun 3, 2026
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/s PR size: S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants