Skip to content

fix(ci): use cache for eslint/prettier/typecheck to speed up dev cycle#1390

Merged
Hweinstock merged 1 commit into
aws:mainfrom
Hweinstock:fix/use-eslint-cache
May 27, 2026
Merged

fix(ci): use cache for eslint/prettier/typecheck to speed up dev cycle#1390
Hweinstock merged 1 commit into
aws:mainfrom
Hweinstock:fix/use-eslint-cache

Conversation

@Hweinstock
Copy link
Copy Markdown
Contributor

@Hweinstock Hweinstock commented May 27, 2026

Description

Adds --cache to eslint and prettier, and --incremental to tsc across npm scripts and the lint-staged pre-commit hook.

Benchmarks

Tool Cold Warm (cached) Speedup
ESLint 38.5s 4.0s ~9.5x
Prettier 9.9s 2.8s ~3.5x
TypeScript 12.4s 7.2s ~1.7x

References

Related Issue

Closes #

Documentation PR

N/A

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Other (please describe): Developer experience / performance improvement

Testing

How have you tested the change?

  • I ran npm run test:unit and npm run test:integ
  • I ran npm run typecheck
  • I ran npm run lint
  • If I modified src/assets/, I ran npm run test:update-snapshots and committed the updated snapshots

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.

@github-actions github-actions Bot added size/xs PR size: XS agentcore-harness-reviewing AgentCore Harness review in progress labels May 27, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added the claude-security-reviewing Claude Code /security-review in progress label May 27, 2026
@agentcore-devx-automation
Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label May 27, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Package Tarball

aws-agentcore-0.15.0.tgz

How to install

gh release download pr-1390-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.15.0.tgz

Copy link
Copy Markdown

@agentcore-cli-automation agentcore-cli-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Small, focused change that's safe to merge:

  • All three tools support the flags at the pinned versions (ESLint 9, Prettier 3, TS 5).
  • .eslintcache, .cache, and *.tsbuildinfo are already in .gitignore, so no risk of accidentally committing cache artifacts.
  • Prettier writes its cache under node_modules/.cache/prettier/ by default; ESLint and TS write to repo root — none of these intersect with what CI persists between runs (CI only restores node_modules keyed on npm-shrinkwrap.json, so stale caches from prior CI runs aren't a concern).
  • lint-staged passing specific file paths with --cache works correctly — the cache is keyed per file.

Nice speedup for local dev iteration.

@github-actions github-actions Bot removed the agentcore-harness-reviewing AgentCore Harness review in progress label May 27, 2026
@Hweinstock Hweinstock changed the title Enable caching for eslint, prettier, and typecheck fix(ci): use cache for eslint/prettier/typecheck to speed up dev cycle May 27, 2026
@Hweinstock Hweinstock marked this pull request as ready for review May 27, 2026 13:36
@Hweinstock Hweinstock requested a review from a team May 27, 2026 13:36
@Hweinstock Hweinstock marked this pull request as draft May 27, 2026 13:36
@Hweinstock Hweinstock marked this pull request as ready for review May 27, 2026 13:37
@Hweinstock Hweinstock merged commit abc6c5a into aws:main May 27, 2026
28 of 29 checks passed
@Hweinstock Hweinstock deleted the fix/use-eslint-cache branch May 27, 2026 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xs PR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants