Skip to content

fix: replace third-party base image with AWS public ECR image (CVE-2026-31789) #1250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jesseturner21 merged 4 commits into from
May 14, 2026
Merged

fix: replace third-party base image with AWS public ECR image (CVE-2026-31789) #1250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
742c90b
fix: replace third-party base image with AWS public ECR image
jesseturner21 May 14, 2026
e1ce981
fix: address review — use pip install uv, fix import command, update …
jesseturner21 May 14, 2026
b42d661
fix: pin python base image to bookworm for reproducible builds
jesseturner21 May 14, 2026
ed2d440
fix: unpin uv version — install latest via pip
jesseturner21 May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docs/container-builds.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,8 @@ app/MyAgent/

## Generated Dockerfile

The template uses `ghcr.io/astral-sh/uv:python3.12-bookworm-slim` as the base image with these design choices:
The template uses `public.ecr.aws/docker/library/python:3.12-slim` as the base image (with `uv` installed via
`pip install uv`) with these design choices:

- **Layer caching**: Dependencies (`pyproject.toml`) are installed before copying application code
- **Non-root**: Runs as `bedrock_agentcore` (UID 1000)
Expand Down
8 changes: 6 additions & 2 deletions src/assets/__tests__/__snapshots__/dockerfile-render.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
// Vitest Snapshot v1, https://vitest.dev/guide/snapshot.html

exports[`Dockerfile enableOtel rendering > renders opentelemetry-instrument CMD when enableOtel is true > Dockerfile-enableOtel-true 1`] = `
"FROM ghcr.io/astral-sh/uv:python3.12-bookworm-slim
"FROM public.ecr.aws/docker/library/python:3.12-slim-bookworm

RUN pip install --no-cache-dir uv

ARG UV_DEFAULT_INDEX
ARG UV_INDEX
Expand Down Expand Up @@ -39,7 +41,9 @@ CMD ["opentelemetry-instrument", "python", "-m", "main"]
`;

exports[`Dockerfile enableOtel rendering > renders plain python CMD when enableOtel is false > Dockerfile-enableOtel-false 1`] = `
"FROM ghcr.io/astral-sh/uv:python3.12-bookworm-slim
"FROM public.ecr.aws/docker/library/python:3.12-slim-bookworm

RUN pip install --no-cache-dir uv

ARG UV_DEFAULT_INDEX
ARG UV_INDEX
Expand Down
4 changes: 3 additions & 1 deletion src/assets/container/python/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
FROM ghcr.io/astral-sh/uv:python3.12-bookworm-slim
FROM public.ecr.aws/docker/library/python:3.12-slim-bookworm

RUN pip install --no-cache-dir uv

ARG UV_DEFAULT_INDEX
ARG UV_INDEX
Expand Down
3 changes: 2 additions & 1 deletion src/cli/commands/import/actions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,7 +383,8 @@ export async function handleImport(options: ImportOptions): Promise<ImportResult
fs.writeFileSync(
destDockerfile,
[
'FROM ghcr.io/astral-sh/uv:python3.12-bookworm-slim',
'FROM public.ecr.aws/docker/library/python:3.12-slim-bookworm',
'RUN pip install --no-cache-dir uv',
'WORKDIR /app',
'',
'ENV UV_SYSTEM_PYTHON=1 \\',
Expand Down
Loading