Upgrade java version from java 8 to java 17#432
Merged
SwaySway merged 5 commits intoaws-cloudformation:masterfrom Jan 9, 2024
saieshwarm:master
Merged
Upgrade java version from java 8 to java 17#432SwaySway merged 5 commits intoaws-cloudformation:masterfrom saieshwarm:master
SwaySway merged 5 commits intoaws-cloudformation:masterfrom
saieshwarm:master
Conversation
mrinaudo-aws
requested changes
Jan 5, 2024
Contributor
mrinaudo-aws
left a comment
mrinaudo-aws
left a comment
There was a problem hiding this comment.
Hi @saieshwarm - thank you for your time! I see that you have bumped up the JaCoCo dependency to be able to use Java 17, which is great; we also need to bump it up in the generated pom.xml file, that is in python/rpdk/java/templates/init/shared/pom.xml to avoid a java.lang.IllegalArgumentException: Unsupported class file major version 61 on a generated project. Can you please update that file as well?
joshuadeanhall
approved these changes
Jan 6, 2024
SwaySway
approved these changes
Jan 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#Description
AWS Lambda is deprecating java8(Ref). This change will create resource lambdas with Java17 runtime.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.