feat: support Document type serialization#429
Merged
SwaySway merged 4 commits intoaws-cloudformation:masterfrom Nov 17, 2023
Merged
Conversation
himanshs23
reviewed
Nov 7, 2023
Contributor
himanshs23
left a comment
himanshs23
left a comment
There was a problem hiding this comment.
Other code looks good except for the dependency addition
himanshs23
approved these changes
Nov 8, 2023
SwaySway
approved these changes
Nov 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
AWS::Kendra::DataSourcereverted support forTemplateConfiguration. This is because the template present in theTemplateConfigurationwas aDocumenttype that was not supported by thecloudformation-cli-java-plugin. It seems thattemplatewas implemented as a string type when it was initially implemented, so `callGraphs' type resolution failed. This investigation is the cause I personally discovered in the process of cloning and debugging the source and trying to register and deploy it in the CloudFormation Registry.aws-cloudformation/aws-cloudformation-resource-providers-kendra#107
Description of changes:
Add support Document type.
I have confirmed that if
TemplateConfiguration.Templateis implemented by the Document type, it can at least be deployed with CloudFormation Registry.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.