Log response payload for better troubleshooting#320
Merged
sungkkim merged 4 commits intoaws-cloudformation:masterfrom Oct 23, 2020
Merged
Log response payload for better troubleshooting#320sungkkim merged 4 commits intoaws-cloudformation:masterfrom
sungkkim merged 4 commits intoaws-cloudformation:masterfrom
Conversation
ammokhov
reviewed
Oct 22, 2020
wbingli
reviewed
Oct 22, 2020
| } | ||
|
|
||
| protected void writeResponse(final OutputStream outputStream, final ProgressEvent<ResourceT, CallbackT> response) | ||
| protected void writeResponse(final OutputStream outputStream, |
There was a problem hiding this comment.
This seems a break change for the generated code. I would suggest you do following to keep backward compatible. And also update the code generate to use new method. In such way, it won't break old code if still use old plugin, but it just won't have additional logging data.
After updated the plugin tool, it can then benefit with new feature.
protected void writeResponse(final OutputStream outputStream,final ProgressEvent<ResourceT, CallbackT> response) {
this(outputStream, response, null);
}
ammokhov
approved these changes
Oct 23, 2020
wbingli
pushed a commit
to wbingli/cloudformation-cli-java-plugin
that referenced
this pull request
Dec 5, 2020
…mation#320)" This reverts commit 4bdae6e.
wbingli
pushed a commit
to wbingli/cloudformation-cli-java-plugin
that referenced
this pull request
Dec 5, 2020
…mation#320)" This reverts commit 4bdae6e.
wbingli
pushed a commit
that referenced
this pull request
Dec 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
319
Description of changes:
This change adds logging of stack id, logical resource id and response payload to aid in troubleshooting.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.