feat: add Prometheus metrics, health checks, and readiness endpoints#528
Open
lakhansamani wants to merge 1 commit intomainfrom
Open
feat: add Prometheus metrics, health checks, and readiness endpoints#528lakhansamani wants to merge 1 commit intomainfrom
lakhansamani wants to merge 1 commit intomainfrom
Conversation
- Add github.com/prometheus/client_golang dependency - Create internal/metrics package registering HTTPRequestsTotal, HTTPRequestDuration, AuthEventsTotal, and ActiveSessions collectors - Add HealthCheck(ctx) method to the storage.Provider interface and implement it for all six DB providers (sql, mongodb, arangodb, cassandradb, dynamodb, couchbase) - Replace the simple /health string handler with a storage-backed JSON liveness handler (/healthz) and a new readiness handler (/readyz) - Add MetricsMiddleware() and MetricsHandler() to the http_handlers.Provider interface and implement them - Register /healthz, /readyz, /metrics routes and MetricsMiddleware in the Gin router - Call metrics.Init() during server startup in cmd/root.go - Add integration tests for /healthz and /readyz endpoints
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HealthCheck(ctx)on all 6 DB providers (SQL, MongoDB, ArangoDB, Cassandra, DynamoDB, Couchbase)/healthzendpoint (storage health),/readyzendpoint (storage + memory store),/metricsendpoint (Prometheus)Related
Ref: RFC #506
Test plan
go build ./...— compiles cleango test -p 1 -v -run "TestHealthHandler|TestReadyHandler" ./internal/integration_tests//metricsendpoint returns Prometheus format/healthzreturns{"status":"ok"}with healthy DB🤖 Generated with Claude Code