Support integer parts-per-second time unit#2227
Open
petermm wants to merge 1 commit intoatomvm:release-0.7from
Open
Support integer parts-per-second time unit#2227petermm wants to merge 1 commit intoatomvm:release-0.7from
petermm wants to merge 1 commit intoatomvm:release-0.7from
Conversation
petermm
force-pushed
the
feature/integer-time-unit
branch
from
6560e8c to
dad612d
Compare
Add support for positive integer time units ("parts per second") in
erlang:monotonic_time/1, erlang:system_time/1, and
calendar:system_time_to_universal_time/2.
Restrict integer-unit handling to int64 inputs in the affected NIF paths.
Use checked int64 decomposition for monotonic/system time conversion to
avoid signed overflow in intermediate arithmetic. For calendar integer
units, floor negative fractional values to whole seconds before converting
to UTC.
Add focused Erlang tests for integer-unit parity, badarg on non-positive
integer units, and negative fractional calendar conversion for integer
units.
Signed-off-by: Peter M <petermm@gmail.com>
petermm
force-pushed
the
feature/integer-time-unit
branch
from
dad612d to
1f640b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for positive integer time units ("parts per second") in erlang:monotonic_time/1, erlang:system_time/1, and calendar:system_time_to_universal_time/2.
Used in elixir DynamicSupervisor - completes the timeunit support.
Restrict integer-unit handling to int64 inputs in the affected NIF paths. Use checked int64 decomposition for monotonic/system time conversion to avoid signed overflow in intermediate arithmetic. For calendar integer units, floor negative fractional values to whole seconds before converting to UTC.
Add focused Erlang tests for integer-unit parity, badarg on non-positive integer units, and negative fractional calendar conversion for integer units.
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later