Can't see staged/unstaged changes for files with a question mark in the file name

@rerodrigues commented on Jul 23, 2018, 3:53 PM UTC:

Prerequisites

• Put an X between the brackets on this line if you have done all of the following:
  • Reproduced the problem in Safe Mode: https://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
  • Followed all applicable steps in the debugging guide: https://flight-manual.atom.io/hacking-atom/sections/debugging/
  • Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
  • Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
  • Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description

When clicking in a new or modified file in the git panel, if the filename contains a questions mark, Atom gets lost.

Steps to Reproduce

1. Create or modify a file with a question mark in the name (ex. users?name=John)
2. Click on this file in the git panel.

Expected behavior: [What you expect to happen]
The changes made on the file since the last version to be displayed.

Actual behavior: [What actually happens]

• the file shows empty on a suspended tab
• the git the panel shows the "Initialize a new project directory with a Git repository" default message.
• the status bar git applet shows "0 Files", and all the git related commands disappears

Reproduces how often: [What percentage of the time does it reproduce?]
100% of the times

Versions

 Atom    : 1.28.2
 Electron: 2.0.5
 Chrome  : 61.0.3163.100
 Node    : 8.9.3

apm  1.19.0
npm  3.10.10
node 6.9.5 x64
atom 1.28.2
python 2.7.10
git 2.15.1

ProductName:	 Mac OS X
ProductVersion: 10.13.4
BuildVersion: 17E199

Additional Information

Any additional information, configuration or data that might be necessary to reproduce the issue.

I have a mock server that everytime you hit an unmocked URL it creates a mocked version of the response replicating the URL and querystring structure of the request on the file system. This is the reason of the filenames with a question mark in the name.

Edit:
Console output:

Unable to locate git workspace root for atom-github:/file-patch/test.json?teste?workdir=%2FUsers%2Frenrodrigues%2Fdev%2Ftestdir&stagingStatus=unstaged. Expected if atom-github:/file-patch/test.json?teste?workdir=%2FUsers%2Frenrodrigues%2Fdev%2Ftestdir&stagingStatus=unstaged is not in a git repository. Error: ENOENT: no such file or directory, stat 'atom-github:/file-patch/test.json?teste?workdir=%2FUsers%2Frenrodrigues%2Fdev%2Ftestdir&stagingStatus=unstaged'

This issue was moved by rsese from atom/atom#17730.

[rsese]

Thanks for the report @rerodrigues - I can reproduce with Atom 1.30.0-dev-4a5ac6623 on macOS 10.12.6.

[annthurium]

thanks for reporting, @rerodrigues!

Just merged a fix. It will go out in the next release of the GitHub package (0.20.0).

[rerodrigues]

Thanks @annthurium! This was a small but really annoying bug! 😆