Skip to content

Create plug that loads the current tenant assign from a given header…#60

Closed
t00lmaker wants to merge 27 commits into
ateliware:masterfrom
t00lmaker:add_plug_header
Closed

Create plug that loads the current tenant assign from a given header…#60
t00lmaker wants to merge 27 commits into
ateliware:masterfrom
t00lmaker:add_plug_header

Conversation

@t00lmaker
Copy link
Copy Markdown

Create plug hat loads the current tenant assign from a given header…

@coveralls
Copy link
Copy Markdown

coveralls commented Oct 31, 2018

Coverage Status

Coverage decreased (-2.2%) to 86.829% when pulling 927a3ab on t00lmaker:add_plug_header into f49c43f on ateliware:master.

Comment thread package-test/LICENSE Outdated
@@ -0,0 +1,21 @@
MIT License
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove this whole folder and amend it to the previous commit? We don't need this. :)

Copy link
Copy Markdown
Contributor

@kelvinst kelvinst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments. Also, please remove the triplex-1.3.0-dev.tar file you commited.

Comment thread lib/mix/triplex.ex Outdated
Co-Authored-By: t00lmaker <luanpontes2@gmail.com>
@mgiacomini
Copy link
Copy Markdown
Contributor

@t00lmaker could you resolve the mix.exs conflicts before we merge this pr?

@kelvinst
Copy link
Copy Markdown
Contributor

kelvinst commented Mar 4, 2019

Thanks for the PR! We will review and merge it soon!

Also, this will be released on version 1.4, which we will also extract a triplex_plugs lib with the plugs there, so triplex will no longer have these here.

@GusGA
Copy link
Copy Markdown

GusGA commented Apr 19, 2019

This PR could be helpful to others and looks abandoned, Can I fork it and fix the issues so could be merged?

@kelvinst
Copy link
Copy Markdown
Contributor

@GusGA we are moving all the plugs from this repo to another one, and we will probably move this one altogether. @mgiacomini please do not forget to copy the plug of this PR to that new triplex_plugs project.

@ghost
Copy link
Copy Markdown

ghost commented May 31, 2019

Excellent news @kelvinst, thanks for your effort.

@kelvinst
Copy link
Copy Markdown
Contributor

Hey @mgiacomini, let's merge this to master before separating the plugs on another repository. SO that way @t00lmaker takes the credit for it at least. 😄 Thanks BTW.

@kelvinst kelvinst changed the title Create plug hat loads the current tenant assign from a given header… Create plug that loads the current tenant assign from a given header… Sep 16, 2019
Copy link
Copy Markdown
Contributor

@kelvinst kelvinst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I deleted all the package-test files you added, but cannot delete triplex-1.3.0-dev.tar, @t00lmaker can you delete and update the PR please?

@kelvinst kelvinst mentioned this pull request Sep 16, 2019
@mgiacomini
Copy link
Copy Markdown
Contributor

Hey @mgiacomini, let's merge this to master before separating the plugs on another repository. SO that way @t00lmaker takes the credit for it at least. 😄 Thanks BTW.

Sure!

@t00lmaker t00lmaker closed this Oct 26, 2019
@t00lmaker t00lmaker deleted the add_plug_header branch October 26, 2019 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants