Skip to content

Fix get momentum acceptance#1086

Merged
SebastienJoly merged 5 commits into
masterfrom
fix_get_momentum_acceptance
Jun 4, 2026
Merged

Fix get momentum acceptance#1086
SebastienJoly merged 5 commits into
masterfrom
fix_get_momentum_acceptance

Conversation

@SebastienJoly

Copy link
Copy Markdown
Collaborator

I added some square brackets around 'dp' in get_momentum_acceptance to solve the bug reported in: #1084
Now I can use get_momentum_acceptance and get_lifetime as before.

@SebastienJoly SebastienJoly requested review from lfarv and swhite2401 June 4, 2026 09:05
@SebastienJoly SebastienJoly marked this pull request as ready for review June 4, 2026 09:05
@SebastienJoly SebastienJoly linked an issue Jun 4, 2026 that may be closed by this pull request

@swhite2401 swhite2401 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good for me!

@swhite2401 swhite2401 self-requested a review June 4, 2026 12:31

@swhite2401 swhite2401 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sorry, no in fact you have the changes in the wiggler PR there...I guess if you merge the wiggler first and then this one it is fine

@SebastienJoly

Copy link
Copy Markdown
Collaborator Author

Oops I went too fast when creating the new branch. I restored the file gwig.c.

@SebastienJoly SebastienJoly merged commit 7414e40 into master Jun 4, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mismatch between npoints and planes when calling get_acceptance()

2 participants