Refactoring of magnet integrators#1083
Open
lfarv wants to merge 6 commits into
Open
Conversation
Contributor
|
Dear @lfarv, to review I may simply run some basic tracking, DA, etc on this branch compared to the master? thank you |
Contributor
Author
|
@simoneliuzzo: of course you are welcome to use the branch for all kinds of optics computation: this helps a lot in validating the modifications. I recall the expected behaviour:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is a full refactoring of the magnet passmethods.
It uses include files which can be combined to generate all the different magnet passmethods. At the moment, this is based on:
6 Propagation methods:
5 kick methods
3 geometry descriptions
2 integrators
And a single integrator template: magnet_template.h
With this, the standard StrMPoleSymplectic4Pass pass method is written as:
And the corresponding radiative passmethod is written as:
Obviously you can't mix randomly propagation and kicks. But creating new passmethods is easy, like for instance a 6th order
StrMPoleSymplectic6Pass:Or a quantum diffusion version
ExactSectorBendQuantPass: