Skip to content

Add method overload to equals with diff #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
glibas merged 3 commits into from
Jun 15, 2020
Merged

Add method overload to equals with diff #71

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
56d9bf6
add comment to Snapshot class
jpratt2 Jun 5, 2020
450faa2
add method overload to equalsWithDiff
jpratt2 Jun 12, 2020
bbe4804
remove an unwanted comment
jpratt2 Jun 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/main/java/com/assertthat/selenium_shutterbug/core/Snapshot.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,8 +277,7 @@ public boolean equals(BufferedImage image, double deviation) {
* @return true if the the provided image and current image are strictly equal.
*/
public boolean equalsWithDiff(BufferedImage image, String resultingImagePath) {
if (this.getImage() == image) return true;
return getImage() != null ? ImageProcessor.imagesAreEqualsWithDiff(getImage(), image, resultingImagePath, 0) : image == null;
return equalsWithDiff(image, resultingImagePath,0);
}

/**
Expand All @@ -298,8 +297,7 @@ public boolean equalsWithDiff(BufferedImage image, String resultingImagePath, do
* @return true if the the provided image and current image are strictly equal.
*/
public boolean equalsWithDiff(Snapshot image, String resultingImagePath) {
if (this == image) return true;
return getImage() != null ? ImageProcessor.imagesAreEqualsWithDiff(getImage(), image.getImage(),resultingImagePath, 0) : image == null;
return equalsWithDiff(image, resultingImagePath,0);
}

/**
Expand Down