Cascade client view default to existing clients with confirmation

[priosshrsth]

What

Applies a workspace client-view default change to every existing client's view setting, with an IU confirmation step before the destructive override.

Stacked on top of anit/out-3851-cu-view-settings-foundation.

Changes

workspaceSettings.service.ts

• Wrap the workspace-setting update and the per-client cascade updateMany in a single $transaction (using the repo's setTransaction/unsetTransaction pattern) so they commit atomically.
• Only cascade values that actually changed (diff against the previous row).
• clientHideSubtasks maps to the inverse of the per-user showSubtasks flag.

ClientViewSettingsSection.tsx

• Confirmation modal before applying a default change ("Update view for all clients?").
• Optimistic update with rollback preserved through the confirm flow.
• Guard no-op dropdown changes so the modal doesn't pop when the value is unchanged.

Notes

• The aria ids on StyledModal follow the existing repo-wide ConfirmUI convention.

Screenshots

New confirmation UI

2026-06-15.16-11-16.mov

🤖 Generated with Claude Code

[linear-code]

OUT-3851

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
tasks-app	Ready	Preview, Comment	Jun 15, 2026 9:57am

[greptile-apps]

Greptile Summary

This PR adds a confirmation step before cascading a workspace-level client-view default to all existing clients, and wraps the workspace-setting update plus the per-client updateMany in a single atomic Prisma transaction so both either commit or roll back together.

• Service (workspaceSettings.service.ts): introduces $transaction with setTransaction/unsetTransaction (guarded by try/finally), fetches the previous row inside the transaction to diff only truly changed fields, and maps clientHideSubtasks to the inverse showSubtasks on ViewSetting.
• UI (ClientViewSettingsSection.tsx): adds a pendingSettings state so controls remain at the committed value until the user confirms; the optimistic update and rollback path flow correctly through handleConfirm → persist; the no-op guard on the dropdown prevents spurious modal appearances for same-value selections.

Confidence Score: 5/5

Safe to merge; the transaction logic, diff-only cascade, and UI rollback path all hold up under inspection.

The transaction wraps both writes atomically, the try/finally guard correctly restores this.db even when the cascade throws, and the optimistic-update rollback in the UI captures the right prior state. The only finding is a dangling aria-labelledby/aria-describedby pair on the confirmation modal that has no functional impact on the cascade logic itself.

The ARIA attributes on the StyledModal in ClientViewSettingsSection.tsx reference IDs that ConfirmUI does not render — worth fixing before this ships to ensure the modal is accessible to screen-reader users.

Important Files Changed

Filename	Overview
src/app/api/workspace-settings/workspaceSettings.service.ts	Wraps workspace-setting update and per-client view cascade in a single Prisma transaction using setTransaction/unsetTransaction; correctly guards cascade behind a diff check; the tx-as-PrismaClient cast (pre-existing thread) remains.
src/app/configure-tasks-app/ui/ClientViewSettingsSection.tsx	Adds confirmation modal before cascading view-setting changes; optimistic update with rollback is correctly preserved; aria-labelledby/aria-describedby on StyledModal reference IDs that ConfirmUI never renders.

Sequence Diagram

sequenceDiagram
    actor User
    participant UI as ClientViewSettingsSection
    participant API as updateWorkspaceSettings (action)
    participant Svc as WorkspaceSettingsService
    participant DB as Prisma / DB

    User->>UI: Changes dropdown or switch
    UI->>UI: setPendingSettings(next)
    UI->>User: Show confirmation modal
    User->>UI: Clicks "Apply to all clients"
    UI->>UI: setPendingSettings(null) — closes modal
    UI->>UI: setSettings(next) — optimistic update
    UI->>API: updateWorkspaceSettings(token, next)
    API->>Svc: updateWorkspaceSettings(data)
    Svc->>DB: $transaction start
    DB-->>Svc: tx client
    Svc->>Svc: setTransaction(tx)
    Svc->>DB: workspaceSetting.findUnique (previous)
    DB-->>Svc: previous row
    Svc->>DB: workspaceSetting.update(data)
    DB-->>Svc: updated row
    Svc->>Svc: diff(previous, data) → cascade fields
    Svc->>DB: viewSetting.updateMany (all clients in workspace)
    DB-->>Svc: n rows updated
    Svc->>Svc: unsetTransaction()
    DB-->>API: commit
    API-->>UI: success
    UI->>User: Settings applied

    alt API error
        DB-->>Svc: error (rollback)
        Svc->>Svc: unsetTransaction() [finally]
        API-->>UI: error
        UI->>UI: setSettings(previous) — rollback
        UI->>User: Settings reverted
    end

Loading

_{Reviews (2): Last reviewed commit: "Restore db handle in finally so cascade ..." | Re-trigger Greptile}

[vercel]

Deployment failed with the following error:

Deploying Serverless Functions to multiple regions is restricted to the Pro and Enterprise plans.

Learn More: https://vercel.link/multiple-function-regions

[SandipBajracharya]

lgtm