Skip detail page SSR for HEAD requests#1318
Draft
cursor[bot] wants to merge 2 commits into
Draft
Conversation
Co-authored-by: Neil Raina <makeitraina@users.noreply.github.com>
Co-authored-by: Neil Raina <makeitraina@users.noreply.github.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
src/proxy.tsguard for/detail/:path*that returns a no-store 200 for HEAD requests before the task detail page runs SSR loaders.Testing Criteria
yarn test src/proxy.test.ts- validates matcher scope plus HEAD/GET behavior.yarn lint:check -- src/proxy.ts src/proxy.test.ts- completed with existing repo warnings only, no errors.yarn tsc- attempted; blocked by existing unrelated SVG module declaration errors insrc/icons/index.ts.yarn devandcurl -Iagainst/detail/9474a765-95dc-445f-aaca-7f950acdbdce/iu?token=test-tokenreturned200withcache-control: no-store, and the dev server logged no page-render errors for that HEAD request.Notes
TASKS-94in thetasksproject.HEAD /detail/[task_id]/[user_type], across 6 Sentry groups. TASKS-94 specifically failed inSubtaskService.getSubtaskCountswithCan't reach database server at aws-0-us-east-1.pooler.supabase.com:6543.Impact & Surface Area of Change
/detail/:path*are short-circuited.