Skip to content

Handle null Copilot email notification responses#1289

Draft
cursor[bot] wants to merge 1 commit into
mainfrom
cursor/OUT-3834-cursor-automated-triage-response-b8af
Draft

Handle null Copilot email notification responses#1289
cursor[bot] wants to merge 1 commit into
mainfrom
cursor/OUT-3834-cursor-automated-triage-response-b8af

Conversation

@cursor

@cursor cursor Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Changes

  • Allow Copilot createNotification to return null for email-only notification payloads without raising a ZodError.
  • Keep in-product notification flows strict and add guards before persisting notification IDs.
  • Update reminder email dispatcher/helper tests for null email-only responses.

Testing Criteria

  • yarn test src/jobs/notifications/send-reminder-email.test.ts src/jobs/notifications/dispatch-reminder-email.test.ts --runInBand (12/12 passed)
  • yarn lint:check (0 errors; existing React hook/compiler warnings remain)
  • yarn tsc --project tsconfig.notification-check.json --noEmit using a temporary narrow config for changed notification modules (passed)
  • yarn tsc --noEmit attempted; blocked by pre-existing missing SVG module declarations in src/icons/index.ts.

Notes

  • Sentry issue: TASKS-8R / Linear OUT-3834. Latest event shows job=dispatch-reminder-email and a ZodError parsing null as NotificationCreatedResponse.
  • Linear MCP returned auth_revoked, so I could not post the required ticket comment from this environment.

Impact & Surface Area of Change

  • Notification sending through CopilotAPI#createNotification now has a nullable return type for email-only sends.
  • Reminder email jobs can complete successfully when Copilot accepts an email-only send without creating an in-product notification record.
  • In-product notification persistence paths now explicitly skip/log if Copilot unexpectedly returns no notification object.
Open in Web View Automation 

Co-authored-by: Neil Raina <makeitraina@users.noreply.github.com>
@linear-code

linear-code Bot commented Jun 4, 2026

Copy link
Copy Markdown

OUT-3834

@vercel

vercel Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
tasks-app Ready Ready Preview, Comment Jun 4, 2026 7:45pm

Request Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant