OUT-3815 | OUT-3819: collapse qb_product_sync to one row per product, drop price columns

[SandipBajracharya]

Summary

Stacked on OUT-3816. Combines two tickets plus a transaction-safety fix.

• OUT-3815: add partial unique index uq_qb_product_sync_product_active on (portal_id, product_id) WHERE deleted_at IS NULL.
• OUT-3819: drop the now-vestigial price_id, unit_price, copilot_unit_price columns and remove the legacy unitPrice read in webhookProductUpdated.
• Both schema changes are folded into one migration (20260603102427).
• Hardening (product.service.ts):
  • onConflictDoNothing (scoped to the partial index via where) on the initial-save batch insert, so a re-fired/concurrent save no-ops instead of 500-ing on the new unique constraint.
  • wrap both db.transaction callbacks in try/finally so unsetTransaction() always restores the this.db singleton, even on a throw or early return.

⚠️ Deploy ordering

The one-time dedup SQL lives in the gitignored supabase/snippets/cleanup.sql and must be hand-run against prod before this deploys. build.sh auto-runs drizzle-kit migrate, and the non-concurrent CREATE UNIQUE INDEX aborts if duplicate live rows still exist. The script has a dry-run SELECT followed by the soft-delete UPDATE (keeps the earliest live row per (portal_id, product_id)).

Test plan

• tsc --noEmit clean
• yarn lint:check 0 errors
• yarn test — 286/286 pass (new migration applies cleanly in the testcontainers DB; unique index doesn't collide with seeds)

🤖 Generated with Claude Code

[linear-code]

OUT-3815

OUT-3819

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
quickbooks-sync	Building		Jun 4, 2026 7:38am
quickbooks-sync (dev)	Ready	Preview, Comment	Jun 4, 2026 7:38am

[greptile-apps]

Greptile Summary

This PR enforces one active row per product in qb_product_sync (partial unique index on (portal_id, product_id) WHERE deleted_at IS NULL), drops the vestigial price_id, unit_price, and copilot_unit_price columns, and hardens the two transaction callbacks in product.service.ts with try/finally so unsetTransaction() is always restored.

• Schema / migration: new partial unique index created in a single migration alongside the three DROP COLUMN statements; Drizzle schema and snapshot updated to match.
• Service hardening: handleProductMap now calls getAll() after the onConflictDoNothing insert (fixing the previous RETURNING [] concern), and both db.transaction callbacks gain try/finally so the this.db singleton is restored on early return or exception.
• Test coverage: new integration test (reFiredInitialSave) fires the initial-save endpoint twice and asserts the second call returns the live mapping row rather than an empty array, with no duplicate row created.

Confidence Score: 5/5

Safe to merge — all schema changes are additive or purely drop vestigial columns, service logic is straightforward, and the new integration test directly exercises the conflict path.

Both transaction callbacks are correctly hardened with try/finally, the onConflictDoNothing + getAll() approach properly handles re-fired saves without leaking an empty response, and the migration cleanly removes three unused columns alongside the new partial unique index. The new test locks in the fixed behavior end-to-end.

No files require special attention. The deploy-ordering note (run cleanup.sql before migrating) is documented in the PR description and is the only operational gate.

Important Files Changed

Filename	Overview
src/app/api/quickbooks/product/product.service.ts	Removes returningFields from handleProductMap, replaces bare RETURNING with getAll() after onConflictDoNothing, wraps both transaction callbacks in try/finally so unsetTransaction() is guaranteed even on early return or throw, and drops all unitPrice references.
src/db/migrations/20260603102427_collapse_qb_product_sync_one_row_drop_price_columns.sql	Creates partial unique index uq_qb_product_sync_product_active on (portal_id, product_id) WHERE deleted_at IS NULL, then drops the three vestigial price columns.
src/db/schema/qbProductSync.ts	Drops priceId, unitPrice, copilotUnitPrice columns and adds the partial unique index declaration.
test/integration/quickbooks/productMap/reFiredInitialSave.test.ts	New integration test covering the onConflictDoNothing + getAll() fix end-to-end.
src/hook/useSettings.ts	Removes unitPrice: null assignments from product-mapping payloads.
test/helpers/seed.ts	Removes unitPrice from base product sync seed.
test/integration/quickbooks/invoiceCreated/lineAmountUnitPrice.test.ts	Removes stale unitPrice comment from seed call.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[handleProductMap] --> B[setTransaction tx]
    B --> C{initialProductSettingMap?}
    C -->|false - initial save| D[insert mappingItems + portalId\nonConflictDoNothing on partial index]
    D --> E[return getAll]
    C -->|true - subsequent save| F{changedItemReference length > 0?}
    F -->|yes| G[Promise.all: updateOrCreateQBProduct per item]
    G --> H[return getAll]
    F -->|no| H
    E --> FIN[finally: unsetTransaction]
    H --> FIN
    FIN --> I[transaction committed]

Loading

_{Reviews (2): Last reviewed commit: "fix(OUT-3815): return live mapping from ..." | Re-trigger Greptile}

[greptile-apps]

onConflictDoNothing + RETURNING returns [] on a conflict, which the API sends to the client

PostgreSQL's RETURNING clause only yields rows that were actually inserted; rows skipped by ON CONFLICT DO NOTHING are silently omitted. On a re-fired or concurrent initial save every row will conflict, so products will be []. The controller wraps this in NextResponse.json(products), meaning the frontend receives an empty array and may treat it as the authoritative, empty product list — overwriting whatever state it already had. Consider using onConflictDoUpdate (no-op set) so that RETURNING still yields the surviving rows, or fall through to this.getAll() when the returned array is empty.

[greptile-apps]

Non-concurrent unique index creation takes an ACCESS EXCLUSIVE lock

CREATE UNIQUE INDEX (without CONCURRENTLY) acquires an ACCESS EXCLUSIVE lock on qb_product_sync for the entire duration of the index build, blocking all reads and writes. On a busy production table this will cause visible downtime. CREATE UNIQUE INDEX CONCURRENTLY builds the index without the table-level lock, but it cannot run inside a transaction block — if drizzle-kit migrate wraps statements in a transaction, the CONCURRENTLY keyword must be handled via a raw migration outside that transaction.

[SandipBajracharya]

We're managing all migrations via drizzle-kit. Besides, the records in the table is quiet low (2k) so this might not have severe impact.

[SandipBajracharya]

@greptileai

[priosshrsth]

lgtm