Easier number to Expression#72
Merged
arnaudleclerc merged 5 commits intoJul 8, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #72 +/- ##
========================================
Coverage 86.45% 86.45%
========================================
Files 124 124
Lines 3655 3655
========================================
Hits 3160 3160
Misses 495 495
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Owner
|
Thanks, everything looks fine. That's another great addition to the expressions :) Would you mind also updating the documentation to explain that it is now possible to affect a double directly to an expression ? Otherwise, I am afraid this will remain mostly unknown. You can find the documentation on |
Fix typo
Contributor
Author
|
@arnaudleclerc Sure, docs updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Being an enrichment wrapper around
double?, it makes sense to let compiler convert number to Expression where it needs.The first commit illustrates a single prop forces us to use 2 times new ExpressionOrNumber() even though intend is crystal clear and non-twofold.
@arnaudleclerc what do you think?
Thanks.