Enrich expression API#71
Merged
arnaudleclerc merged 11 commits intoJul 7, 2022
Merged
Conversation
added 6 commits
July 6, 2022 12:15
Contributor
Author
|
@arnaudleclerc Could you please review? Thanks. |
Codecov Report
@@ Coverage Diff @@
## develop #71 +/- ##
========================================
Coverage 86.45% 86.45%
========================================
Files 124 124
Lines 3655 3655
========================================
Hits 3160 3160
Misses 495 495
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Owner
|
@mitikov Thanks for the PR, this is a great improvement! Everything looks fine. Do you think it is possible to add some unit tests on the new code ? |
Contributor
Author
|
@arnaudleclerc Sure, here you go :) |
arnaudleclerc
approved these changes
Jul 7, 2022
Owner
|
Awesome, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding primitive APIs to reduce the volume of boilerplate code to be written while working with expressions.
Inspired by #70