Skip to content

Resolves #104 and #105#112

Merged
arnaudleclerc merged 4 commits into
arnaudleclerc:developfrom
blackboxlogic:develop
Oct 9, 2025
Merged

Resolves #104 and #105#112
arnaudleclerc merged 4 commits into
arnaudleclerc:developfrom
blackboxlogic:develop

Conversation

@blackboxlogic
Copy link
Copy Markdown
Contributor

#105

Removing multiple markers only removes 1.

Removing multiple markers only removes 1.
updating marker options can't be used to make marker invisible (or un-draggable)
@blackboxlogic blackboxlogic changed the title Resolves #105 Resolves #104 and #105 Jun 5, 2025
using UpdateHtmlMarkersAsync() updates the options in stored in c# also. this didn't work:
var options = new AzureMapsControl.Components.Markers.HtmlMarkerOptions { Visible = !Marker.Options.Visible };
@blackboxlogic
Copy link
Copy Markdown
Contributor Author

Also fixing an issue where using UpdateHtmlMarkersAsync didn't update the options in c# memory, so updating an option then getting the value of the option gave the old value. Consider:

	public async Task OnMapClick(MapMouseEventArgs eventArgs)
	{
		var options = new AzureMapsControl.Components.Markers.HtmlMarkerOptions { Visible = !Marker.Options.Visible };

		await eventArgs.Map.UpdateHtmlMarkersAsync(new AzureMapsControl.Components.Markers.HtmlMarkerUpdate(Marker, options));
	}

@blackboxlogic
Copy link
Copy Markdown
Contributor Author

@arnaudleclerc It seems like this repo might not be actively maintained? If that's the case, it might be nice to put that first thing in the README so people know what to expect.

@arnaudleclerc
Copy link
Copy Markdown
Owner

Sorry for the delay @blackboxlogic ! I am not as active anymore on this project as I would like to be.

Your changes look good, thanks for taking care of it.

@arnaudleclerc arnaudleclerc merged commit ef97648 into arnaudleclerc:develop Oct 9, 2025
@blackboxlogic
Copy link
Copy Markdown
Contributor Author

Thank you! It seems like this got released as 1.17.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants