Update NDAttribute datasets to increase in dimension as required Fix #74#81
Merged
ulrikpedersen merged 1 commit intohdf5-issuesfrom Mar 12, 2015
Merged
Update NDAttribute datasets to increase in dimension as required Fix #74#81ulrikpedersen merged 1 commit intohdf5-issuesfrom
ulrikpedersen merged 1 commit intohdf5-issuesfrom
Conversation
) Introduced a new parameter NDAttributeChunk for setting chunking. Updated NDAttribute datasets to use unlimited maximum length and then increase the size as required. If the user stops the collection early then only collected data is stored to the datasets. This resolves issue #74.
Member
|
I've tested this and it works for me. Note that the default value of NDAttributeChunk=0 is probably the best option for 99% of use-cases. Except if you are writing really huge datasets (100.000+ frames). Because of that I think it is OK not to add this parameter to the screens - if someone accidentally (or without understanding the parameter) sets a small value, the performance of writing the attribute datasets may well suffer significantly. |
ulrikpedersen
added a commit
that referenced
this pull request
Mar 12, 2015
Update NDAttribute datasets to increase in dimension as required Fix #74
This was referenced Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduced a new parameter NDAttributeChunk for setting chunking. Updated
NDAttribute datasets to use unlimited maximum length and then increase the
size as required. If the user stops the collection early then only
collected data is stored to the datasets.
This resolves issue #74.