Skip to content

feat: Apple SDK update for version 17.1.1#113

Merged
abnegate merged 2 commits into
mainfrom
dev
May 19, 2026
Merged

feat: Apple SDK update for version 17.1.1#113
abnegate merged 2 commits into
mainfrom
dev

Conversation

@ArnabChatterjee20k

@ArnabChatterjee20k ArnabChatterjee20k commented May 19, 2026

Copy link
Copy Markdown
Member

This PR contains updates to the Apple SDK for version 17.1.1.

What's Changed

  • Fixed: Removed Advisor service and Insight, InsightCTA, InsightList, Report, ReportList models (admin-only endpoints, not intended for client SDKs)
  • Added: sizeActual field to File model

@greptile-apps

greptile-apps Bot commented May 19, 2026

Copy link
Copy Markdown

Greptile Summary

This PR bumps the Apple SDK to version 17.1.1, removing the admin-only Advisor service and its five associated model files, and adding a sizeActual field to the File model.

  • Advisor removal: Advisor.swift, Insight, InsightCTA, InsightList, Report, and ReportList are all deleted; the CHANGELOG now correctly lists all five removed models and the four matching example docs are gone.
  • File model update: sizeActual: Int is added as a required (non-optional) field, decoded with a hard container.decode and force-cast as! Int in from(map:). Clients on SDK 17.1.1 pointing at a server version that does not yet include this field will receive a DecodingError.keyNotFound or a fatal crash on every file-related response (noted in a prior review comment that remains unaddressed).
  • Version bump: x-sdk-version header and the README SPM snippet updated to 17.1.1.

Confidence Score: 4/5

The Advisor removal is clean, but sizeActual is decoded as a hard-required field with a force-cast, meaning any client targeting a server that omits this field will crash or throw on every file API call.

The Advisor deletions are straightforward and correctly reflected in the changelog. The only meaningful risk is in File.swift: sizeActual is decoded with container.decode (not decodeIfPresent) and accessed via as! Int in from(map:), with no server-version gating (x-appwrite-response-format is still 1.9.5). A client on this SDK version communicating with an older Appwrite server will hit a DecodingError.keyNotFound or a runtime crash on every storage endpoint. This issue was raised in a previous review round and has not yet been addressed.

Sources/AppwriteModels/File.swift — the sizeActual field decoding and force-cast

Important Files Changed

Filename Overview
Sources/AppwriteModels/File.swift Adds required (non-optional) sizeActual: Int field; decoded with hard decode and force-cast as! Int — will throw/crash against servers that don't return this field yet
Sources/Appwrite/Services/Advisor.swift Deleted: entire Advisor service removed as it was admin-only and not intended for client SDKs
Sources/Appwrite/Client.swift Version bump from 17.1.0 to 17.1.1 in SDK header; no functional changes
CHANGELOG.md 17.1.1 entry now correctly lists all five removed models (Insight, InsightCTA, InsightList, Report, ReportList) and the added sizeActual field
README.md SPM dependency version reference updated from 17.1.0 to 17.1.1; no other changes

Reviews (2): Last reviewed commit: "chore: update Apple SDK to 17.1.1" | Re-trigger Greptile

Comment thread CHANGELOG.md
@abnegate abnegate merged commit f73be6a into main May 19, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants