Skip to content

[v0.9] Fix failed lambda execution crashing coordinator#1580

Merged
Siegrift merged 3 commits into
v0.9from
proper-lambda-error-handling-0.9
Dec 5, 2022
Merged

[v0.9] Fix failed lambda execution crashing coordinator#1580
Siegrift merged 3 commits into
v0.9from
proper-lambda-error-handling-0.9

Conversation

@Siegrift

@Siegrift Siegrift commented Dec 1, 2022

Copy link
Copy Markdown
Contributor

Closes #1565

@Siegrift Siegrift requested review from a team and amarthadan December 1, 2022 17:58
@Siegrift Siegrift self-assigned this Dec 1, 2022
@Siegrift Siegrift force-pushed the proper-lambda-error-handling-0.9 branch from f6697b4 to 164682a Compare December 1, 2022 17:58
@Siegrift Siegrift changed the title Fix failed lambda execution crashing coordinator [v0.9] Fix failed lambda execution crashing coordinator Dec 1, 2022
@Siegrift

Siegrift commented Dec 1, 2022

Copy link
Copy Markdown
Contributor Author

@amarthadan I wasn't able to build Docker images locally and the CI fails as well (also for the 0.9 branch). I've tried building also on Linux locally, but got an error as well.

I've tried to debug the issue, but I gave that up after a while. I 100% remember testing this and it used to work for me.
I've tested this using the deployer package directly.

@amarthadan

Copy link
Copy Markdown
Contributor

@amarthadan I wasn't able to build Docker images locally and the CI fails as well (also for the 0.9 branch). I've tried building also on Linux locally, but got an error as well.

I've tried to debug the issue, but I gave that up after a while. I 100% remember testing this and it used to work for me. I've tested this using the deployer package directly.

I'll take a look.

@amarthadan

Copy link
Copy Markdown
Contributor

Ok, found what the issue with Docker builds is, tracked and described in #1585.

@Siegrift Siegrift force-pushed the proper-lambda-error-handling-0.9 branch from d5f9980 to ee7708b Compare December 5, 2022 08:45
@Siegrift Siegrift merged commit cf382ad into v0.9 Dec 5, 2022
@Siegrift Siegrift deleted the proper-lambda-error-handling-0.9 branch December 5, 2022 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants