[Laravel]: Fix authorization swagger ui#6661
Conversation
|
Nice! Tyvm! Would you be able to squash your commits and reword it and follow the convetional commits? See https://github.com/api-platform/core/blob/main/CONTRIBUTING.md#sending-a-pull-request it'd could be like this: Thanks! |
|
@soyuka yes, once im done i will squash commit. Different question: First way / issue, would be adding the option to pass a auth key type via the OpenApiFactory, by adapting this code. It is a non-breaking change (and the way i did it in this PR). But the drawback here is that api-platform already uses Second way (which removes this confusion a bit) would be to adapt the Options file, with a new property and method (getHttpAuth or smth. like that). And use that additionally in the That would be more consistent tbh. However to avoid breaking changes in the Options Class, i would need to append those values at the end of the constructor. What would be the preferred way here? |
|
And also: Is this a feature or a bug? Since it is already somewhat implemented but not really working in laravel - i considered it a bug...if you consider it a feature please let me know (because i think i will also need to merge it to a differen branch then right?) |
|
I see 2 different things here. For Laravel we consider that every existing feature that is missing as a bug fix for 4.x and therefore the |
fix swagger ui authentication in laravel, by providing necessary options Closes: #6662
4b79c8e to
1d6ee85
Compare
|
ok updated to fix only the config, i will make a new PR as feature to support http auth. |
|
Many thanks! |

Uh oh!
There was an error while loading. Please reload this page.