fix(hydra): Fix server-side validation errors do not show up#613
Merged
Conversation
soyuka
approved these changes
Apr 8, 2025
djhi
approved these changes
Apr 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Contrary to what the docs say, server-side validation errors do not appear beneath the related input.
At least when using
<HydraAdmin>with API Platform 4.1 using Symfony.Solution
Fix the
getSubmissionErrorsimplementation.Real-world tests show that validation errors are formatted like so:
whereas the existing code seems to expect them like so:
The new implementation I suggest is compatible with both.
How to Test
A unit test was added.
Besides, this can be tested in Storybook.
Book.phpfile to add a constraint to the$isbnfield:#[Assert\Isbn]docker compose up