feat: Try to generalize and refactor connection pool from workflows

[ad-claw000]

Fixes #598

[Copilot]

Pull request overview

This PR introduces a new ConnectionPool utility into the aperturedb Python SDK (ported/refactored from the workflows repo) and adds unit tests to validate basic pooling behavior.

Changes:

• Added aperturedb/ConnectionPool.py implementing a queue-backed, context-manager-based connection pool.
• Added test/test_ConnectionPool.py with unit tests for initialization, checkout/return, and query forwarding.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File	Description
aperturedb/ConnectionPool.py	Adds the new ConnectionPool implementation and a convenience query() method.
test/test_ConnectionPool.py	Adds tests covering pool sizing, get_connection() context management, and query() forwarding.

Comments suppressed due to low confidence (2)

aperturedb/ConnectionPool.py:83

• query(self, query: str, blobs: list = [], ...) uses a mutable default ([]). If callers mutate blobs, that state can leak across calls. Prefer blobs: Optional[list] = None and normalize to [] inside the method.

    def query(self, query: str, blobs: list = [], **kwargs):
        """

aperturedb/ConnectionPool.py:60

• The pool swallows connection creation errors (prints and continues), but _pool_size remains the requested size and total() reports that number even if fewer connections were actually created. Either fail fast when the pool cannot be fully populated, or track the actual number of created connections and have total() reflect reality (and/or expose both requested vs created).

        # Pre-populate the pool with connections
        for _ in range(pool_size):
            try:
                connection = self._connection_factory()
                if not connection:
                    raise ConnectionError("Failed to create a connection.")
                self._pool.put(connection)
            except Exception as e:
                print(f"Failed to create a connection for the pool: {e}")
                # Depending on requirements, you might want to raise an error
                # if the pool cannot be fully populated.

        if self.available() == 0:
            raise ConnectionError(
                "Failed to initialize any connections for the pool. "
                "Please check connection parameters and network."
            )

    def available(self) -> int:
        """Returns the number of available connections in the pool."""
        return self._pool.qsize()

    def total(self) -> int:
        """Returns the total number of connections in the pool."""
        return self._pool_size

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[luisremis]

there is already a pr for this #666