fix(utils): censor token information in error logs#668
Closed
ad-claw000 wants to merge 7 commits into
Closed
Conversation
ad-claw000
force-pushed
the
fix/545-log-exposes-tokens
branch
from
7d8ba3b to
38d5320
Compare
Closes #545. Ensures that `get_last_response_str()` does not leak sensitive token information if an error occurs when `Utils.execute()` throws an exception.
ad-claw000
force-pushed
the
fix/545-log-exposes-tokens
branch
from
f562542 to
dd10aa5
Compare
Contributor
Author
|
Closing in favor of #672, which extracts the logic into a common function. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #545
When a query fails inside
Utils.execute(), the full JSON response was being dumped to the error log viaget_last_response_str(). In some cases, this response would include active session tokens and refresh tokens from earlier in the batch.This PR parses the JSON response right before it is logged and replaces any tokens with
***CENSORED***.