fix: remove redundant connection close in SSLError catch block (Closes #625)#654
Merged
Conversation
luisremis
previously approved these changes
Apr 22, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes redundant connection teardown in the SSL socket-wrapping error path, relying on the existing outer BaseException handler to close the connection consistently (per issue #625).
Changes:
- Removed
self.conn.close()andself.connected = Falsefrom theexcept ssl.SSLErrorblock inside_connect. - Keeps connection cleanup centralized in the outer
except BaseExceptionhandler.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #625. Removed the redundant connection close and assignment inside the
ssl.SSLErrorcatch block since the re-raised exception is natively caught and closed correctly by theBaseExceptionblock immediately underneath.