Skip to content

chore: bump golangci version go version and fix spinnermsg printf#671

Merged
shanshanying merged 4 commits into
mainfrom
fix/govet-spinnermsg-printf
May 14, 2026
Merged

chore: bump golangci version go version and fix spinnermsg printf#671
shanshanying merged 4 commits into
mainfrom
fix/govet-spinnermsg-printf

Conversation

@shanshanying
Copy link
Copy Markdown
Contributor

@shanshanying shanshanying commented May 14, 2026

No description provided.

@shanshanying @claude
fix: resolve govet printf non-constant format string in spinnerMsg calls
0150a7d 
Replace runtime string concatenation with format placeholders in
spinnerMsg calls to satisfy govet's printf analyzer.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@github-actions github-actions Bot added the size/L Denotes a PR that changes 100-499 lines. label May 14, 2026
@shanshanying shanshanying changed the title Fix/govet spinnermsg printf chore: bump golangci version go version and fix spinnermsg printf May 14, 2026
@shanshanying
Copy link
Copy Markdown
Contributor Author

shanshanying commented May 14, 2026

/approve to trigger test

@shanshanying shanshanying force-pushed the fix/govet-spinnermsg-printf branch from 2512631 to 9bb040e Compare May 14, 2026 09:30
@shanshanying @claude
chore: bump go version to 1.25 and update golangci-lint to v2.8.0
a003d08 
- Update go.mod to go 1.25.0 / toolchain go1.25.10
- Update Makefile: go mod tidy compat to 1.25, golangci-lint to v2.8.0
- Migrate .golangci.yaml to v2 format

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@shanshanying shanshanying force-pushed the fix/govet-spinnermsg-printf branch from 9bb040e to a003d08 Compare May 14, 2026 09:41
@shanshanying @claude
chore: update embedded charts and addons submodule
930d6ed 
Generated by make generate during lint verification.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@shanshanying
Copy link
Copy Markdown
Contributor Author

shanshanying commented May 14, 2026

/approve

@shanshanying shanshanying merged commit d8c9efe into main May 14, 2026
5 checks passed
@shanshanying shanshanying deleted the fix/govet-spinnermsg-printf branch May 14, 2026 09:58
@github-actions github-actions Bot added this to the Release 1.0 milestone May 14, 2026
@shanshanying
Copy link
Copy Markdown
Contributor Author

shanshanying commented May 14, 2026

/cherry-pick release-1.1

@apecloud-bot
Copy link
Copy Markdown
Collaborator

apecloud-bot commented May 14, 2026

🤖 says: Error cherry-picking.

Failed to merge submodule addons (not checked out)
hint: Recursive merging with submodules currently only supports trivial cases.
hint: Please manually handle the merging of each conflicted submodule.
hint: This can be accomplished with the following steps:
hint: - come back to superproject and run:
hint:
hint: git add addons
hint:
hint: to record the above merge or update
hint: - resolve any other conflicts in the superproject
hint: - commit the resulting index in the superproject
hint:
hint: Disable this message with "git config set advice.submoduleMergeConflict false"
CONFLICT (submodule): Merge conflict in addons
Auto-merging go.mod
error: could not apply d8c9efe... chore: bump golangci version go version and fix spinnermsg printf (#671)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config set advice.mergeConflict false"

@apecloud-bot
Copy link
Copy Markdown
Collaborator

apecloud-bot commented May 14, 2026

🤖 says: ‼️ cherry pick action failed.
See: https://github.com/apecloud/kbcli/actions/runs/25853879695

shanshanying added a commit that referenced this pull request May 14, 2026
@shanshanying @claude
chore: bump golangci version go version and fix spinnermsg printf (#671)
350e725 
Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
Co-authored-by: shanshanying <shanshanying@users.noreply.github.com>
shanshanying added a commit that referenced this pull request May 14, 2026
@shanshanying @claude
chore: bump golangci version go version and fix spinnermsg printf (#671)
f102f27 
Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
Co-authored-by: shanshanying <shanshanying@users.noreply.github.com>
shanshanying added a commit that referenced this pull request May 14, 2026
@shanshanying @claude
chore: bump golangci version go version and fix spinnermsg printf (#671)
9c30e2c 
Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
Co-authored-by: shanshanying <shanshanying@users.noreply.github.com>
shanshanying added a commit that referenced this pull request May 14, 2026
@shanshanying @claude
chore: bump golangci version go version and fix spinnermsg printf (#671)
87bede4 
Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
Co-authored-by: shanshanying <shanshanying@users.noreply.github.com>
shanshanying added a commit that referenced this pull request May 14, 2026
@shanshanying @claude
chore: bump golangci version go version and fix spinnermsg printf (#671)
f2e4802 
Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
Co-authored-by: shanshanying <shanshanying@users.noreply.github.com>
shanshanying added a commit that referenced this pull request May 14, 2026
@shanshanying @claude
chore: bump golangci version go version and fix spinnermsg printf (#671…
4f62d15 
…) (#672)

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
Co-authored-by: shanshanying <shanshanying@users.noreply.github.com>
shanshanying added a commit that referenced this pull request May 14, 2026
@shanshanying @claude
chore: bump golangci version go version and fix spinnermsg printf (#671…
f721ff4 
…) (#673)

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
Co-authored-by: shanshanying <shanshanying@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ldming ldming ldming approved these changes

@wangyelei wangyelei wangyelei approved these changes

@JashBook JashBook JashBook approved these changes

@apecloud-bot apecloud-bot apecloud-bot approved these changes

@nayutah nayutah Awaiting requested review from nayutah nayutah is a code owner

@1aal 1aal Awaiting requested review from 1aal 1aal is a code owner

Assignees

No one assigned

Labels

size/L Denotes a PR that changes 100-499 lines.

Projects

None yet

Milestone

Release 1.0

Development

Successfully merging this pull request may close these issues.

5 participants

@shanshanying @apecloud-bot @ldming @wangyelei @JashBook