[ETHOSN] Add support for non-default Ethos(TM)-N78 configurations#9386
Merged
manupak merged 1 commit intoapache:mainfrom Oct 29, 2021
Merged
[ETHOSN] Add support for non-default Ethos(TM)-N78 configurations#9386manupak merged 1 commit intoapache:mainfrom
manupak merged 1 commit intoapache:mainfrom
Conversation
- Updated tvmc with new Ethos-N78 composite target. - Added additional Ethos-N78 specific configuration options. Co-authored-by: Tristan O'Connor <tristan.oconnor@arm.com>
leo-blonk
requested review from
MarisaKirisame,
ZihengJiang,
anijain2305,
areusch,
comaniac,
jroesch,
junrushao,
jwfromm,
leandron,
manupak,
mbaret,
mbrookhart,
merrymercy,
slyubomirsky,
tqchen,
trevor-m,
vinx13,
wweic,
yzhliu and
zhiics
as code owners
4 tasks
lhutton1
reviewed
Oct 28, 2021
Contributor
lhutton1
left a comment
lhutton1
left a comment
There was a problem hiding this comment.
Just something I picked up on while skimming through, will leave to others to review in more depth :)
Comment on lines
+73
to
+84
| if params: | ||
| mod["main"] = bind_params_by_name(mod["main"], params) | ||
|
|
||
| seq = tvm.transform.Sequential( | ||
| [ | ||
| transform.InferType(), | ||
| transform.MergeComposite(pattern_table()), | ||
| transform.AnnotateTarget("ethos-n"), | ||
| transform.MergeCompilerRegions(), | ||
| transform.PartitionGraph(), | ||
| ] | ||
| ) |
Contributor
There was a problem hiding this comment.
This looks the same as what's in partition_for_ethosn78? Maybe its best to wrap this in another function rather than duplicate functionality
Contributor
Author
There was a problem hiding this comment.
Yes, I have noticed this too, but would suggest to do this as an follow-on patch, amongst some other cleanup I want to do.
Contributor
|
Thanks @lhutton1 @Leo-arm. |
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 7, 2022
…ache#9386) - Updated tvmc with new Ethos-N78 composite target. - Added additional Ethos-N78 specific configuration options. Co-authored-by: Tristan O'Connor <tristan.oconnor@arm.com> Co-authored-by: Tristan O'Connor <tristan.oconnor@arm.com>
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
…ache#9386) - Updated tvmc with new Ethos-N78 composite target. - Added additional Ethos-N78 specific configuration options. Co-authored-by: Tristan O'Connor <tristan.oconnor@arm.com> Co-authored-by: Tristan O'Connor <tristan.oconnor@arm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Tristan O'Connor tristan.oconnor@arm.com