[Hexagon] Launcher modifications to make use of the new device API#9356
Merged
jroesch merged 6 commits intoapache:mainfrom Oct 26, 2021
csullivan:app/hexagon_launcher_use_new_device_api
Merged
[Hexagon] Launcher modifications to make use of the new device API#9356jroesch merged 6 commits intoapache:mainfrom csullivan:app/hexagon_launcher_use_new_device_api
jroesch merged 6 commits intoapache:mainfrom
csullivan:app/hexagon_launcher_use_new_device_api
Conversation
app/hexagon_launcher.
so that CopyDataFromTo knows how to handle the provided memory.
utilize NDArray's for copying in order to exercise the DeviceAPI.
csullivan
requested review from
comaniac,
jroesch,
junrushao,
tqchen,
yzhliu and
zhiics
as code owners
jroesch
approved these changes
Oct 26, 2021
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 7, 2022
…pache#9356) * Use custom lookup_linked_params function in app/hexagon_launcher. * Use new device api in hexagon launcher. * Ensure app/hexagon_launcher uses kDLCPU for external allocations so that CopyDataFromTo knows how to handle the provided memory. * Use loadfile_hexagon in app/hexagon_launcher. * Update hexagon launcher's get_output method to utilize NDArray's for copying in order to exercise the DeviceAPI. * Apply clang formatting
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
…pache#9356) * Use custom lookup_linked_params function in app/hexagon_launcher. * Use new device api in hexagon launcher. * Ensure app/hexagon_launcher uses kDLCPU for external allocations so that CopyDataFromTo knows how to handle the provided memory. * Use loadfile_hexagon in app/hexagon_launcher. * Update hexagon launcher's get_output method to utilize NDArray's for copying in order to exercise the DeviceAPI. * Apply clang formatting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes enable the use of the new hexagon device api in the hexagon launcher.
Changes include,
loadfile_hexagonDepends on #9355, with transitive dependencies on #9354, #9342.