[CUDA] Support memory reuse for dynamic shared memory#9341
Merged
Hzfengsy merged 7 commits intoapache:mainfrom Oct 31, 2021
Merged
[CUDA] Support memory reuse for dynamic shared memory#9341Hzfengsy merged 7 commits intoapache:mainfrom
Hzfengsy merged 7 commits intoapache:mainfrom
Conversation
Contributor
Author
Member
|
Hmm, for reuse on the constant-size dynamic shmem, I thought the existing |
Member
|
I think this is to support reusing heterogenous data type allocs |
Contributor
Author
|
Member
|
Thanks @jinhongyii, that you are able to reduce the alloc size from |
Member
|
Let's double check and get it in if there is no further issue :-) |
Hzfengsy
requested changes
Oct 25, 2021
Contributor
Author
vinx13
reviewed
Oct 30, 2021
vinx13
approved these changes
Oct 30, 2021
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 7, 2022
* reuse shared dyn * minor * format * format * address comment and fix * address comment * address comment
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
* reuse shared dyn * minor * format * format * address comment and fix * address comment * address comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR applies part of the algorithm of storage rewrite to detect memory reuse possibility for dynamic shared memory, and does rewrite to the body. This functionality is important in matmul because we may want to allocate the shared memory for data fetch and the shared memory for write back in the same location.