[PyTorch][Frontend] Semantic difference of 'bias_add' between relay and pytorch#9204
Merged
masahi merged 3 commits intoapache:mainfrom Oct 7, 2021
Merged
[PyTorch][Frontend] Semantic difference of 'bias_add' between relay and pytorch#9204masahi merged 3 commits intoapache:mainfrom
masahi merged 3 commits intoapache:mainfrom
Conversation
soodoshll
requested review from
Huyuwei,
jwfromm,
kazum,
mbrookhart,
siju-samuel and
srkreddy1238
as code owners
Member
|
Thanks, can you add a test? |
junrushao
approved these changes
Oct 6, 2021
Member
junrushao
left a comment
junrushao
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the bugfix!
soodoshll
requested review from
areusch,
comaniac,
jroesch,
merrymercy,
tqchen and
yzhliu
as code owners
Contributor
Author
|
@masahi Hi, test is also fixed. |
Member
|
Thanks @soodoshll |
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 7, 2022
…nd pytorch (apache#9204) * fix bias_add * add test * add test
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
…nd pytorch (apache#9204) * fix bias_add * add test * add test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greetings. I encountered a problem when trying translating Pytorch models into relay.
relay.nn.bias_addhas a defaultaxis=1, which is inconsistent with linear in PyTorch (when ndim>2), which always adds bias to the last dimension. So it is necessary to explicitly assignaxis=-1here.Thanks @spectrometerHBH for helping debug. cc @junrushao1994