Skip to content

[TVMScript] Script namespace changes#9115

Merged
junrushao merged 1 commit intoapache:mainfrom
Hzfengsy:script_namesapce
Oct 1, 2021
Merged

[TVMScript] Script namespace changes#9115
junrushao merged 1 commit intoapache:mainfrom
Hzfengsy:script_namesapce

Conversation

@Hzfengsy
Copy link
Copy Markdown
Member

@Hzfengsy Hzfengsy commented Sep 25, 2021 •
edited
Loading

Script namespace changes. Please see the RFC: apache/tvm-rfcs#36.

This PR would be extreme huge, but most of them are unittests refactoring.

Co-authored-by: Junru Shao junrushao1994@gmail.com
Co-authored-by: Zihao Ye zihaoye.cs@gmail.com

@Hzfengsy
Copy link
Copy Markdown
Member Author

Hzfengsy commented Sep 25, 2021

cc @tqchen @junrushao1994 @tkonolige

@Hzfengsy Hzfengsy force-pushed the script_namesapce branch 2 times, most recently from 4e7784f to a0c3cf1 Compare September 26, 2021 05:05
MasterJH5574
MasterJH5574 reviewed Sep 27, 2021
View reviewed changes
Comment thread python/tvm/ir/module.py Outdated
@Hzfengsy Hzfengsy mentioned this pull request Sep 27, 2021
Merged
tkonolige
tkonolige approved these changes Sep 27, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@tkonolige tkonolige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good. I think I managed to read through all the files :). There's a couple of small changes that would be good to have. And I'd also like to understand why are change the return value of tvm.script.ir_module.

Comment thread python/tvm/tir/function.py Outdated
Comment thread python/tvm/topi/arm_cpu/cortex_m7/micro_kernel/gemm.py Outdated
Comment thread python/tvm/script/parser.py Outdated
Comment thread tests/python/unittest/test_aot_legalize_packed_call.py
Comment thread tests/python/unittest/test_tvmscript_spans.py Outdated
@altanh altanh mentioned this pull request Sep 27, 2021
Merged
@junrushao
Copy link
Copy Markdown
Member

junrushao commented Sep 29, 2021

Thanks @Hzfengsy for the hard work, greatly improving the TVMScript syntax! Let's move quickly, address comments and get this PR merged :-)

@Hzfengsy Hzfengsy requested a review from leandron as a code owner September 30, 2021 02:50
@Hzfengsy Hzfengsy force-pushed the script_namesapce branch 3 times, most recently from b3b3287 to 67c2016 Compare September 30, 2021 09:13
@Hzfengsy Hzfengsy force-pushed the script_namesapce branch 6 times, most recently from d49d531 to f1cf815 Compare October 1, 2021 10:37
@junrushao @yzh119 @tkonolige
namespace
d489f5b 
Co-authored-by: Junru Shao <junrushao1994@gmail.com>
Co-authored-by: Zihao Ye <zihaoye.cs@gmail.com>
Co-authored-by: Tristan Konolige <tristan.konolige@gmail.com>
@junrushao junrushao merged commit e7af601 into apache:main Oct 1, 2021
@spectrometerHBH spectrometerHBH mentioned this pull request Oct 2, 2021
Merged
@Hzfengsy Hzfengsy deleted the script_namesapce branch October 2, 2021 07:12
Mousius added a commit to Mousius/tvm that referenced this pull request Oct 12, 2021
@Mousius
Fix USMP parallel to serial loop transform test
93e8e6a 
Caused by apache#8469 being stale on merge when apache#9115 had changed the namespace for `tvm.script`.
@Mousius Mousius mentioned this pull request Oct 12, 2021
Merged
mbaret pushed a commit that referenced this pull request Oct 12, 2021
@Mousius
Fix USMP parallel to serial loop transform test (#9254)
f4922bc 
Caused by #8469 being stale on merge when #9115 had changed the namespace for `tvm.script`.
Mousius added a commit to Mousius/tvm that referenced this pull request Oct 14, 2021
@Mousius
Reset sphinx-gallery version to 0.4.0
7557538 
Seeing:
```
ERROR: Could not find a version that satisfies the requirement sphinx-gallery==0.4.1 (from versions: 0.0.4, 0.0.5, 0.0.6, 0.0.7, 0.0.8, 0.0.10, 0.0.11.post1, 0.1.0, 0.1.1, 0.1.2, 0.1.3, 0.1.4, 0.1.5, 0.1.6, 0.1.7, 0.1.8, 0.1.9, 0.1.10, 0.1.11, 0.1.12, 0.1.13, 0.2.0, 0.3.0, 0.3.1, 0.4.0, 0.5.0, 0.6.0, 0.6.1, 0.6.2, 0.7.0, 0.8.0, 0.8.1, 0.8.2, 0.9.0, 0.10.0)
ERROR: No matching distribution found for sphinx-gallery==0.4.1
```

This was changed in apache#9115
@Mousius Mousius mentioned this pull request Oct 14, 2021
Merged
masahi pushed a commit to Laurawly/tvm-1 that referenced this pull request Oct 14, 2021
@Mousius @masahi
Fix USMP parallel to serial loop transform test (apache#9254)
ed28667 
Caused by apache#8469 being stale on merge when apache#9115 had changed the namespace for `tvm.script`.
tqchen pushed a commit that referenced this pull request Oct 14, 2021
@Mousius
Reset sphinx-gallery version to 0.4.0 (#9280)
59b3cf7 
Seeing:
```
ERROR: Could not find a version that satisfies the requirement sphinx-gallery==0.4.1 (from versions: 0.0.4, 0.0.5, 0.0.6, 0.0.7, 0.0.8, 0.0.10, 0.0.11.post1, 0.1.0, 0.1.1, 0.1.2, 0.1.3, 0.1.4, 0.1.5, 0.1.6, 0.1.7, 0.1.8, 0.1.9, 0.1.10, 0.1.11, 0.1.12, 0.1.13, 0.2.0, 0.3.0, 0.3.1, 0.4.0, 0.5.0, 0.6.0, 0.6.1, 0.6.2, 0.7.0, 0.8.0, 0.8.1, 0.8.2, 0.9.0, 0.10.0)
ERROR: No matching distribution found for sphinx-gallery==0.4.1
```

This was changed in #9115
@junrushao junrushao mentioned this pull request Nov 2, 2021
Closed
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 7, 2022
@junrushao @yzh119
@tkonolige @ylc
[TVMScript] Script namespace changes (apache#9115)
8a141ac 
Co-authored-by: Junru Shao <junrushao1994@gmail.com>
Co-authored-by: Zihao Ye <zihaoye.cs@gmail.com>
Co-authored-by: Tristan Konolige <tristan.konolige@gmail.com>
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 7, 2022
@Mousius @ylc
Fix USMP parallel to serial loop transform test (apache#9254)
695de94 
Caused by apache#8469 being stale on merge when apache#9115 had changed the namespace for `tvm.script`.
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 7, 2022
@Mousius @ylc
Reset sphinx-gallery version to 0.4.0 (apache#9280)
50c5929 
Seeing:
```
ERROR: Could not find a version that satisfies the requirement sphinx-gallery==0.4.1 (from versions: 0.0.4, 0.0.5, 0.0.6, 0.0.7, 0.0.8, 0.0.10, 0.0.11.post1, 0.1.0, 0.1.1, 0.1.2, 0.1.3, 0.1.4, 0.1.5, 0.1.6, 0.1.7, 0.1.8, 0.1.9, 0.1.10, 0.1.11, 0.1.12, 0.1.13, 0.2.0, 0.3.0, 0.3.1, 0.4.0, 0.5.0, 0.6.0, 0.6.1, 0.6.2, 0.7.0, 0.8.0, 0.8.1, 0.8.2, 0.9.0, 0.10.0)
ERROR: No matching distribution found for sphinx-gallery==0.4.1
```

This was changed in apache#9115
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 13, 2022
@junrushao @yzh119
@tkonolige @ylc
[TVMScript] Script namespace changes (apache#9115)
dc30704 
Co-authored-by: Junru Shao <junrushao1994@gmail.com>
Co-authored-by: Zihao Ye <zihaoye.cs@gmail.com>
Co-authored-by: Tristan Konolige <tristan.konolige@gmail.com>
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 13, 2022
@Mousius @ylc
Fix USMP parallel to serial loop transform test (apache#9254)
f48272d 
Caused by apache#8469 being stale on merge when apache#9115 had changed the namespace for `tvm.script`.
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 13, 2022
@Mousius @ylc
Reset sphinx-gallery version to 0.4.0 (apache#9280)
7e2cfa6 
Seeing:
```
ERROR: Could not find a version that satisfies the requirement sphinx-gallery==0.4.1 (from versions: 0.0.4, 0.0.5, 0.0.6, 0.0.7, 0.0.8, 0.0.10, 0.0.11.post1, 0.1.0, 0.1.1, 0.1.2, 0.1.3, 0.1.4, 0.1.5, 0.1.6, 0.1.7, 0.1.8, 0.1.9, 0.1.10, 0.1.11, 0.1.12, 0.1.13, 0.2.0, 0.3.0, 0.3.1, 0.4.0, 0.5.0, 0.6.0, 0.6.1, 0.6.2, 0.7.0, 0.8.0, 0.8.1, 0.8.2, 0.9.0, 0.10.0)
ERROR: No matching distribution found for sphinx-gallery==0.4.1
```

This was changed in apache#9115
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MasterJH5574 MasterJH5574 MasterJH5574 left review comments

@tkonolige tkonolige tkonolige approved these changes

@tqchen tqchen tqchen approved these changes

@junrushao junrushao junrushao approved these changes

@areusch areusch Awaiting requested review from areusch

@comaniac comaniac Awaiting requested review from comaniac

@Huyuwei Huyuwei Awaiting requested review from Huyuwei

@jcf94 jcf94 Awaiting requested review from jcf94

@jroesch jroesch Awaiting requested review from jroesch

@jwfromm jwfromm Awaiting requested review from jwfromm

@kevinthesun kevinthesun Awaiting requested review from kevinthesun

@kparzysz-quic kparzysz-quic Awaiting requested review from kparzysz-quic

@Laurawly Laurawly Awaiting requested review from Laurawly

@masahi masahi Awaiting requested review from masahi

@mbrookhart mbrookhart Awaiting requested review from mbrookhart

@merrymercy merrymercy Awaiting requested review from merrymercy

@vinx13 vinx13 Awaiting requested review from vinx13

@yzhliu yzhliu Awaiting requested review from yzhliu

@zhiics zhiics Awaiting requested review from zhiics

@ZihengJiang ZihengJiang Awaiting requested review from ZihengJiang

@leandron leandron Awaiting requested review from leandron

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Hzfengsy @junrushao @tkonolige @tqchen @MasterJH5574