[ONNX] Add support for QLinearConcat contrib op#8907
Merged
masahi merged 10 commits intoapache:mainfrom Sep 8, 2021
Merged
Conversation
anwang2009
requested review from
Huyuwei,
areusch,
comaniac,
jroesch,
junrushao,
jwfromm,
kazum,
mbrookhart,
merrymercy,
siju-samuel,
srkreddy1238,
tqchen and
yzhliu
as code owners
Contributor
Author
Contributor
AndrewZhaoLuo
left a comment
AndrewZhaoLuo
left a comment
There was a problem hiding this comment.
A few comments but LGTM
AndrewZhaoLuo
approved these changes
Sep 2, 2021
Contributor
|
Awesome to see this thank you @anwang2009 ! Could you add the [ONNX] tag to the PR? Thank you! |
anwang2009
changed the title
mbrookhart
approved these changes
Sep 3, 2021
Contributor
mbrookhart
left a comment
mbrookhart
left a comment
There was a problem hiding this comment.
LGTM. Looks like you hit a flaky test, try relaunching CI?
Contributor
|
It seems we have a CI error which I'm not sure relates to the PR at all: |
Contributor
If you jostle ci via |
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Sep 29, 2021
* add qlinearconcat op * fix tests * Fix * lint * lint * review * boop ci * fix regression * noop * jostle ci
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
* add qlinearconcat op * fix tests * Fix * lint * lint * review * boop ci * fix regression * noop * jostle ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_scalarto common point where other Q op impls can reach it._qnn.op.concatenatewill requantize as necessary, so there is nothing special necessary that needs to be done here for this Q op.