Skip to content

[TensorIR][M2a] Reduction Factoring (RFactor)#8544

Merged
junrushao merged 9 commits intoapache:mainfrom
MasterJH5574:m2/rfactor
Jul 31, 2021
Merged

[TensorIR][M2a] Reduction Factoring (RFactor)#8544
junrushao merged 9 commits intoapache:mainfrom
MasterJH5574:m2/rfactor

Conversation

@MasterJH5574
Copy link
Copy Markdown
Contributor

This PR is part of the TensorIR upstreaming effort (#7527), which adds the one schedule primitive "rfactor".

cc @junrushao1994 @tqchen @comaniac @jcf94

Comment thread include/tvm/tir/schedule/block_scope.h Outdated
Comment thread include/tvm/tir/schedule/schedule.h Outdated
Comment thread include/tvm/tir/stmt.h Outdated
Comment thread src/tir/ir/expr.cc Outdated
Comment thread src/tir/schedule/state.cc Outdated
Copy link
Copy Markdown
Contributor

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave the core rfactor implement to tomorrow.
Also cc @jcf94 @vinx13 to help review.

Comment thread include/tvm/tir/schedule/schedule.h Outdated
Comment thread include/tvm/tir/stmt.h Outdated
Comment thread python/tvm/tir/schedule/schedule.py Outdated
Comment thread python/tvm/tir/schedule/schedule.py Outdated
Comment thread python/tvm/tir/schedule/schedule.py Outdated
Comment thread python/tvm/tir/schedule/schedule.py
Comment thread python/tvm/tir/schedule/schedule.py
Comment thread python/tvm/tir/schedule/schedule.py Outdated
Comment thread tests/python/unittest/test_tir_schedule_reduction.py Outdated
@tqchen tqchen added the status: need update need update based on feedbacks label Jul 27, 2021
Copy link
Copy Markdown
Contributor

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We should be able to merge this PR when CI is green.

@comaniac comaniac removed the status: need update need update based on feedbacks label Jul 27, 2021
@tqchen
Copy link
Copy Markdown
Member

tqchen commented Jul 29, 2021

@MasterJH5574 , please fix the docstring issues. You can reproduce by following ./tests/scripts/task_sphinx_precheck.sh

@junrushao
Copy link
Copy Markdown
Member

@tqchen looks like this PR is experiencing CPU time out on unittests

@junrushao junrushao merged commit 5012462 into apache:main Jul 31, 2021
ylc pushed a commit to ylc/tvm that referenced this pull request Sep 29, 2021
Co-authored-by: Junru Shao <junrushao1994@gmail.com>
Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>
Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com>
Co-authored-by: Hongyi Jin <3231950289@qq.com>
Co-authored-by: Wuwei Lin <wuwei@apache.org>
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 13, 2022
Co-authored-by: Junru Shao <junrushao1994@gmail.com>
Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>
Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com>
Co-authored-by: Hongyi Jin <3231950289@qq.com>
Co-authored-by: Wuwei Lin <wuwei@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants