[TensorRT, BYOC] Handling a corner case in TRT RemoveDropout pass#8506
Merged
tqchen merged 2 commits intoapache:mainfrom Jul 28, 2021
Merged
[TensorRT, BYOC] Handling a corner case in TRT RemoveDropout pass#8506tqchen merged 2 commits intoapache:mainfrom
tqchen merged 2 commits intoapache:mainfrom
Conversation
Contributor
Author
comaniac
reviewed
Jul 20, 2021
Comment on lines
+1036
to
+1037
| if isinstance(visit.tuple_value, Call) and isinstance(visit.tuple_value.op, Let): | ||
| return visit |
Contributor
There was a problem hiding this comment.
This looks a bit ad-hoc to me. Suggest as follows. Note that I'm not sure if isinstance(visit.tuple_value.op, Op) is the correct expression but you should know what I meant.
if isinstance(visit.tuple_value, Call):
if isinstance(visit.tuple_value.op, Op) and visit.tuple_value.op.name == "nn.dropout" and visit.index == 0:
return visit.tuple_value.args[0]
return visit
Contributor
Author
There was a problem hiding this comment.
Thanks @comaniac . Changed the logic as appropriate.
zxy844288792
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jul 26, 2021
* [TensorRT, BYOC] Handling a corner case in TRT RemoveDropout pass * refactor the logic
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Sep 29, 2021
…ache#8506) * [TensorRT, BYOC] Handling a corner case in TRT RemoveDropout pass * changing visit logic
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
…ache#8506) * [TensorRT, BYOC] Handling a corner case in TRT RemoveDropout pass * changing visit logic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit handles a corner case in TRT RemoveDropout pass. This avoids an error like below