[BYOC] add multi functions support in partition pass#8464
[BYOC] add multi functions support in partition pass#8464comaniac merged 4 commits intoapache:mainfrom
Conversation
comaniac
left a comment
comaniac
left a comment
There was a problem hiding this comment.
LGTM
@leandron the tests in Ethos-N are failed due to the change of function names by this PR. I asked @zxy844288792 to disable them to unblock the CI. Please feel free to re-enable them later on.
Thanks for letting me know. We’ll have a look tomorrow. 👍🏻 |
|
I'll have a look. If we can hold off momentary I might be able to fix this patch. |
|
The hashes need to be updated. I got most of the way through that; I will finish this on Monday. |
|
Thanks @zxy844288792. |
* add support for multi function * address commits and fix lint * fix testcases and using a set to avoid duplicate func name * fix lint
* add support for multi function * address commits and fix lint * fix testcases and using a set to avoid duplicate func name * fix lint
* add support for multi function * address commits and fix lint * fix testcases and using a set to avoid duplicate func name * fix lint
* add support for multi function * address commits and fix lint * fix testcases and using a set to avoid duplicate func name * fix lint
4 participants
If a module contains multiple functions, the partition pass fail with this kind of message:
Check failed: (!module_->ContainGlobalVar(fname)) is false: Global function ccompiler_0 already existsThe reason of that is due to for each function in the module we maintain a AnnotatedRegion object and reset the region_id which region_id is used to form the subfunction name. Here introduces the new naming which will also use the function name to form the final subfunction name.
Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.