[ONNX] Wrap 'If' if it has multiple outputs#8385
Conversation
Without this wrapper, an assertion in from_onnx() will fail with the error message showing ""Number of output mismatch"
|
Thanks for this fix, it makes sense to me. Can you add a test case that triggers the previous error to |
|
@jwfromm |
jwfromm
left a comment
There was a problem hiding this comment.
LGTM, thanks for adding these tests. I think you just need to fix some formatting to pass CI's sanity check. You can do that by running make format or black whatever.py.
|
@jwfromm |
|
@karljang This is now merged. Thanks for taking the initiative to make this fix and congrats on your first commit! |
|
@jwfromm |
* [ONNX] Wrap 'If' if it has multiple outputs Without this wrapper, an assertion in from_onnx() will fail with the error message showing ""Number of output mismatch" * [ONNX] Test If nodes with multiple output tensors * Fix formatting issues
* [ONNX] Wrap 'If' if it has multiple outputs Without this wrapper, an assertion in from_onnx() will fail with the error message showing ""Number of output mismatch" * [ONNX] Test If nodes with multiple output tensors * Fix formatting issues
Without this wrapper, an assertion in from_onnx() will fail with the
error message showing "Number of output mismatch"
The assertion check is here: https://github.com/apache/tvm/blob/main/python/tvm/relay/frontend/onnx.py#L3597