[ONNX Parser] Add warning in case of opset mismatch#8356
Merged
jcf94 merged 2 commits intoapache:mainfrom Jun 29, 2021
Merged
Conversation
jwfromm
approved these changes
Jun 28, 2021
Contributor
jwfromm
left a comment
jwfromm
left a comment
There was a problem hiding this comment.
I like adding this error message, thanks for the change!
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Sep 29, 2021
* add warning in case of opset mismatch * fix CI Co-authored-by: elenaslavutina <elena.slavutina2013@gmail.com>
zxy844288792
pushed a commit
to zxy844288792/tvm
that referenced
this pull request
Mar 4, 2022
* add warning in case of opset mismatch * fix CI Co-authored-by: elenaslavutina <elena.slavutina2013@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I faced with the problem that if I incorrectly pass onnx opset parameter to the onnx frontend I am getting the error with some low level error trace without any hint related to incorrect opset. That was difficult to root the reason due to that. That's likely a rare case since most of the time user will not pass opset and rely on converter to detect it. Still it worth to improve the logging to hint user in case of such a situation
Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.